Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762460AbZD3PdM (ORCPT ); Thu, 30 Apr 2009 11:33:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762952AbZD3Pcj (ORCPT ); Thu, 30 Apr 2009 11:32:39 -0400 Received: from netrider.rowland.org ([192.131.102.5]:37929 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1762460AbZD3Pci (ORCPT ); Thu, 30 Apr 2009 11:32:38 -0400 Date: Thu, 30 Apr 2009 11:32:37 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Sergei Shtylyov cc: David VomLehn , , , Subject: Re: [PATCH 2/5] USB: Provide USB boot device availability notification In-Reply-To: <49F9C305.9020103@ru.mvista.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 25 On Thu, 30 Apr 2009, Sergei Shtylyov wrote: > > +/* The mask of possible USB boot devices depends on what drivers and > > + * options have been configured into the kernel. There are too many > > + * USB network config options to list here, so just assume it is always > > + * possible to have a USB network device. > > + */ > > +static int usb_bootdev_mask = 0 > > +#ifdef CONFIG_USB_SERIAL_CONSOLE > > + | BOOTDEV_CONSOLE_MASK > > +#endif > > +#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB) > > It should be ||, not bitwise | here, no? No, it should be bitwise |. The value being constructed is a union of disjoint mask bits. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/