Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764283AbZD3QAe (ORCPT ); Thu, 30 Apr 2009 12:00:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753462AbZD3QAO (ORCPT ); Thu, 30 Apr 2009 12:00:14 -0400 Received: from emroute2.ornl.gov ([160.91.86.17]:65203 "EHLO emroute2.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764215AbZD3QAJ (ORCPT ); Thu, 30 Apr 2009 12:00:09 -0400 X-Greylist: delayed 2521 seconds by postgrey-1.27 at vger.kernel.org; Thu, 30 Apr 2009 12:00:09 EDT Date: Thu, 30 Apr 2009 11:18:04 -0400 From: David Dillow Subject: Re: Class device namespaces In-reply-to: To: Kay Sievers Cc: Michael Brown , Doug Warzecha , Jean Delvare , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Matt Domsch Message-id: <1241104684.26576.4.camel@lap75545.ornl.gov> MIME-version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-type: text/plain Content-transfer-encoding: 7bit References: <20090428173929.GA5006@sysman-doug.us.dell.com> <20090428215844.GA1396@sysman-doug.us.dell.com> <437908170904282019h6a10ef9dg594002e22842b366@mail.gmail.com> <437908170904291000s10fe6a92q8a595e0bbbd159a6@mail.gmail.com> <437908170904291428k445fc8fdy9b3bb4e78ee91018@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1484 Lines: 33 On Wed, 2009-04-29 at 23:53 +0200, Kay Sievers wrote: > On Wed, Apr 29, 2009 at 23:28, Michael Brown wrote: > > I cant say that I've ever seen any problems due to udev > > cancelling a firmware request. In fact, if I manually trigger a > > request using "echo" from the cmdline, I dont see udev take any action > > with the dell_rbu device. eg (Fedora 10, udev-127-5.fc10): > > If you run: > udevmonitor --udev --env > at the same time, what does it say? > > > I dont see any of the behaviour that you have talked about. If I let > > it sit there for hours, it will stay at that state. It only closes up > > the request_firmware() request when I echo 0 > loading. > > Udev will run in the moment this sysfs device is created, and it > should trigger the removal of the device, if it does not find the > requested firmware file. drivers/firmware/dell_rbu.c does this: req_firm_rc = request_firmware_nowait(THIS_MODULE, FW_ACTION_NOHOTPLUG, "dell_rbu", &rbu_device->dev, &context, callbackfn_rbu); I've not gone looking to verify, but FW_ACTION_NOHOTPLUG implies to me that udev never sees a uevent for it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/