Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764387AbZD3QEA (ORCPT ); Thu, 30 Apr 2009 12:04:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764076AbZD3QDp (ORCPT ); Thu, 30 Apr 2009 12:03:45 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:37776 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762277AbZD3QDn (ORCPT ); Thu, 30 Apr 2009 12:03:43 -0400 Date: Thu, 30 Apr 2009 18:00:54 +0200 From: Ingo Molnar To: Christoph Lameter , Eric Dumazet Cc: Mathieu Desnoyers , Linus Torvalds , Andrew Morton , Nick Piggin , KOSAKI Motohiro , Peter Zijlstra , thomas.pi@arcor.dea, Yuriy Lalym , Linux Kernel Mailing List , ltt-dev@lists.casi.polymtl.ca, Tejun Heo Subject: Re: [PATCH] Fix dirty page accounting in redirty_page_for_writepage() Message-ID: <20090430160054.GB4723@elte.hu> References: <20090430024303.GB19875@Krystal> <20090430133859.GB8329@elte.hu> <20090430141446.GD14696@elte.hu> <20090430143819.GF14696@elte.hu> <20090430150142.GC20580@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 39 * Christoph Lameter wrote: > http://article.gmane.org/gmane.linux.kernel.cross-arch/1128 > http://article.gmane.org/gmane.linux.kernel.cross-arch/1132 > http://article.gmane.org/gmane.linux.kernel.cross-arch/1134 > http://article.gmane.org/gmane.linux.kernel.cross-arch/1138 > http://article.gmane.org/gmane.linux.kernel.cross-arch/1139 > http://article.gmane.org/gmane.linux.kernel.cross-arch/1145 VM stats > http://article.gmane.org/gmane.linux.kernel.cross-arch/1160 NFS stats > http://article.gmane.org/gmane.linux.kernel.cross-arch/1161 Genhd stats > http://article.gmane.org/gmane.linux.kernel.cross-arch/1164 SRCU The new percpu APIs could be used in most of these places already, straight away. This is a really good TODO list for places to enhance. Then a second set of patches could convert percpu_add() / etc. uses to __percpu_add() ... but that should be done by those architectures that need it (and to the extent they need it), because it's not really testable on x86. I dont really like the PER_CPU / CPU_INC etc. type of all-capitals APIs you introduced in the patches above: + __CPU_INC(bt->sequence); + CPU_FREE(bt->sequence); was there any strong reason to go outside the well-established percpu_* name space and call these primitives as if they were macros? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/