Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763539AbZD3Qeh (ORCPT ); Thu, 30 Apr 2009 12:34:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751090AbZD3Qe2 (ORCPT ); Thu, 30 Apr 2009 12:34:28 -0400 Received: from ey-out-2122.google.com ([74.125.78.27]:20414 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbZD3Qe1 convert rfc822-to-8bit (ORCPT ); Thu, 30 Apr 2009 12:34:27 -0400 MIME-Version: 1.0 In-Reply-To: <1241104684.26576.4.camel@lap75545.ornl.gov> References: <20090428215844.GA1396@sysman-doug.us.dell.com> <437908170904282019h6a10ef9dg594002e22842b366@mail.gmail.com> <437908170904291000s10fe6a92q8a595e0bbbd159a6@mail.gmail.com> <437908170904291428k445fc8fdy9b3bb4e78ee91018@mail.gmail.com> <1241104684.26576.4.camel@lap75545.ornl.gov> From: Kay Sievers Date: Thu, 30 Apr 2009 18:34:06 +0200 Message-ID: Subject: Re: Class device namespaces To: David Dillow Cc: Michael Brown , Doug Warzecha , Jean Delvare , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Matt Domsch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1953 Lines: 43 On Thu, Apr 30, 2009 at 17:18, David Dillow wrote: > On Wed, 2009-04-29 at 23:53 +0200, Kay Sievers wrote: >> On Wed, Apr 29, 2009 at 23:28, Michael Brown wrote: >> > I cant say that I've ever seen any problems due to udev >> > cancelling a firmware request.  In fact, if I manually trigger a >> > request using "echo" from the cmdline, I dont see udev take any action >> > with the dell_rbu device. eg (Fedora 10, udev-127-5.fc10): >> >> If you run: >>   udevmonitor --udev --env >> at the same time, what does it say? >> >> > I dont see any of the behaviour that you have talked about. If I let >> > it sit there for hours, it will stay at that state. It only closes up >> > the request_firmware() request when I echo 0 > loading. >> >> Udev will run in the moment this sysfs device is created, and it >> should trigger the removal of the device, if it does not find the >> requested firmware file. > > drivers/firmware/dell_rbu.c does this: > req_firm_rc = request_firmware_nowait(THIS_MODULE, >                                FW_ACTION_NOHOTPLUG, "dell_rbu", >                                &rbu_device->dev, &context, >                                callbackfn_rbu); > > I've not gone looking to verify, but FW_ACTION_NOHOTPLUG implies to me > that udev never sees a uevent for it. Ah, I see. Pretty weird idea to do that with polling, should be better some key that tells udev to ignore the event, and you could listen to the events yourself, instead of checking for them in sysfs at a specific path and fixed name. But looks fine: if (uevent) dev_set_uevent_suppress(f_dev, 0); Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/