Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758098AbZFANpZ (ORCPT ); Mon, 1 Jun 2009 09:45:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755090AbZFANpP (ORCPT ); Mon, 1 Jun 2009 09:45:15 -0400 Received: from fias.uni-frankfurt.de ([141.2.248.1]:33354 "EHLO fias.uni-frankfurt.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753659AbZFANpO (ORCPT ); Mon, 1 Jun 2009 09:45:14 -0400 From: Jan Scholz To: "Rafael J. Wysocki" Cc: Jan Scholz , Benjamin Herrenschmidt , Paul Mackerras , Ingo Molnar , linux-kernel@vger.kernel.org, Adrian Bunk , pm list Subject: Re: [regression, bisected] adb trackpad disappears after suspend to ram References: <878wkl6vce.fsf@scholz.fias.uni-frankfurt.de> <1243549422.17903.10.camel@pasglop> <87tz34n97p.fsf@scholz.fias.uni-frankfurt.de> <200905292010.10615.rjw@sisk.pl> Date: Mon, 01 Jun 2009 15:44:51 +0200 In-Reply-To: <200905292010.10615.rjw@sisk.pl> (Rafael J. Wysocki's message of "Fri, 29 May 2009 20:10:09 +0200") Message-ID: <87fxekxe3w.fsf@scholz.fias.uni-frankfurt.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2159 Lines: 51 "Rafael J. Wysocki" writes: > On Friday 29 May 2009, Jan Scholz wrote: >> Benjamin Herrenschmidt writes: >> >> >> We are too late in the cycle to revert this commit and it really is needed to >> >> fix a more serious issue. Nevertheless knowing that it caused the problem to >> >> appear on your system is also important. >> >> >> >> Ben, do you have an idea what may be going on here? Does __disable_irq() mask >> >> the interrupt on this platform? >> > >> > I suppose so :-) I'll have to check what's going on, it's not >> > immediately clear to me. >> > >> > Cheers, >> > Ben. >> > >> >> >> >> I'd like to see a boot log, preferably containing a suspend-resume in which >> >> the problem was reproduced. >> >> Here is a log from booting, through several suspend cycles, until the >> trackpad disappeared. The first few suspends were done while X was >> running but from the console. As you can tell from lines like >> May 28 23:51:26 [kernel] adb devices: [2]: 2 c4 [3]: 3 1 [7]: 7 1f >> the trackpad was still present. The last suspend was done from within X, >> here the trackpad did not make it. >> May 28 23:58:09 [kernel] adb devices: [2]: 2 c4 [7]: 7 1f >> However, there have been cases, although not in this log, were the >> trackpad has been alive even when suspending from within X. > > This means the problem is probably timing-related. > > Can you please try to comment out suspend_device_irqs() and > resume_device_irqs() in drivers/base/power/main.c and see if that changes > anything? It's not entirely safe (well, that's why the calls are there after > all), but hopefully the box won't hang during this test. > Tried that against v2.6.30-rc7 and it seems to fix the issue. I did ~10 suspend-resume cycles from the console (which worked just like before) and ~20 cycles from within X and the trackpad is still alive. Best, Jan Scholz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/