Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758496AbZFAPed (ORCPT ); Mon, 1 Jun 2009 11:34:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754823AbZFAPdS (ORCPT ); Mon, 1 Jun 2009 11:33:18 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:60417 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752363AbZFAPdK (ORCPT ); Mon, 1 Jun 2009 11:33:10 -0400 Date: Mon, 1 Jun 2009 16:34:18 +0100 From: Alan Cox To: Dmitry Eremin-Solenikov Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, slapin@ossfans.org, maxim.osipov@siemens.com, dmitry.baryshkov@siemens.com, oliver.fendt@siemens.com Subject: Re: [PATCH 08/10] tty_io: export tty_class Message-ID: <20090601163418.465be751@lxorguk.ukuu.org.uk> In-Reply-To: References: <1243868091-5315-1-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-2-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-3-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-4-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-5-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-6-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-7-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-8-git-send-email-dbaryshkov@gmail.com> <1243868091-5315-9-git-send-email-dbaryshkov@gmail.com> <20090601160721.7b262469@lxorguk.ukuu.org.uk> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 593 Lines: 14 > I used class_find_device finding the device with matching minor. Will it be > acceptable, if I just move this code into tty_* file and export it as > to modules? Yes - create a proper tty helper function for doing the job and document what it does. That way if the tty layer is changed it is obvious that this code also needs considering. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/