Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758227AbZFAQzg (ORCPT ); Mon, 1 Jun 2009 12:55:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755606AbZFAQyy (ORCPT ); Mon, 1 Jun 2009 12:54:54 -0400 Received: from victor.provo.novell.com ([137.65.250.26]:58547 "EHLO victor.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756180AbZFAQyw (ORCPT ); Mon, 1 Jun 2009 12:54:52 -0400 From: Gregory Haskins Subject: [KVM PATCH v3 1/3] kvm: fix potential coalesced_mmio leak on shutdown To: avi@redhat.com Cc: chrisw@sous-sol.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 01 Jun 2009 12:54:45 -0400 Message-ID: <20090601165445.18202.2291.stgit@dev.haskins.net> In-Reply-To: <20090601165134.18202.87598.stgit@dev.haskins.net> References: <20090601165134.18202.87598.stgit@dev.haskins.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 34 It would appear that we are invoking kfree() on the wrong pointer in the destructor for the coalesced_mmio device. This could result in a potential leak during shutdown. This works today because the kvm_io_device is the first element of the private structure, but this could change in the future, so lets clean this up. Signed-off-by: Gregory Haskins --- virt/kvm/coalesced_mmio.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c index 5ae620d..03ea280 100644 --- a/virt/kvm/coalesced_mmio.c +++ b/virt/kvm/coalesced_mmio.c @@ -80,7 +80,10 @@ static void coalesced_mmio_write(struct kvm_io_device *this, static void coalesced_mmio_destructor(struct kvm_io_device *this) { - kfree(this); + struct kvm_coalesced_mmio_dev *dev = + (struct kvm_coalesced_mmio_dev *)this->private; + + kfree(dev); } int kvm_coalesced_mmio_init(struct kvm *kvm) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/