Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759129AbZFAUmi (ORCPT ); Mon, 1 Jun 2009 16:42:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756112AbZFAUm3 (ORCPT ); Mon, 1 Jun 2009 16:42:29 -0400 Received: from dallas.jonmasters.org ([72.29.103.172]:50958 "EHLO dallas.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754152AbZFAUm3 (ORCPT ); Mon, 1 Jun 2009 16:42:29 -0400 Subject: Re: [PATCH]:Return proper error value on failure of dentry_open From: Jon Masters To: vibi_sreenivasan@cms.com Cc: Mimi Zohar , Kylene Hall , Serge Hallyn , Reiner Sailer , linux-kernel In-Reply-To: <1243836708.2163.3.camel@system> References: <1243836708.2163.3.camel@system> Content-Type: text/plain Organization: World Organi[sz]ation Of Broken Dreams Date: Mon, 01 Jun 2009 16:37:54 -0400 Message-Id: <1243888674.31439.26.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-1.fc10) Content-Transfer-Encoding: 7bit X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: jonathan@jonmasters.org X-SA-Exim-Scanned: No (on dallas.jonmasters.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 534 Lines: 15 On Mon, 2009-06-01 at 11:41 +0530, vibi sreenivasan wrote: > dentry_open can return error value on error. > Check that value before calling fput & return proper error value I know you're going to redo this patch. Could you please also post with a better subject next time? :) Jon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/