Message-Id: <200906020230.n522UjfJ013581@www262.sakura.ne.jp>
Subject: Re: [PATCH 2/5] TOMOYO: Clarify lock protected section.
From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: lizf@cn.fujitsu.com
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Date: Tue, 02 Jun 2009 11:30:45 +0900
References: <200906020143.n521hGGP003698@www262.sakura.ne.jp> <4A248C90.9010904@cn.fujitsu.com>
In-Reply-To: <4A248C90.9010904@cn.fujitsu.com>
Content-Type: text/plain; charset="ISO-2022-JP"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 958
Lines: 29

Li Zefan wrote:
> Tetsuo Handa wrote:
> > Enclose reader section in
> > 	/***** READER SECTION START *****/
> > and
> > 	/***** READER SECTION END *****/
> > and writer section in
> > 	/***** WRITER SECTION START *****/
> > and
> > 	/***** WRITER SECTION END *****/
> > in order to avoid oversighting lock protected section.
> > 
> 
> This makes me a bit uncomfortable..
> 
> IMHO this seems ugly, useless, and even harmful. If it's helpful,
> we'd be doing this for the whole kernel tree, which is crazy..
> 
> Or does tomoyo do this for it's special reason?

I intended to help reviewers to visualize the range of protected section
at a glance. But if reviewers feel noisy, I can remove these markers.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/