From: Frans Pop <elendil@planet.nl>
To: Shaohua Li <shaohua.li@intel.com>
Subject: Re: [SOLVED] Build failure caused by 'cpuidle: makes AMD C1E work in acpi_idle'
Date: Tue, 2 Jun 2009 04:49:30 +0200
User-Agent: KMail/1.9.9
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
       "Brown, Len" <len.brown@intel.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <200906011858.10575.elendil@planet.nl> <20090602010150.GA21166@sli10-desk.sh.intel.com>
In-Reply-To: <20090602010150.GA21166@sli10-desk.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906020449.32339.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1634
Lines: 40

On Tuesday 02 June 2009, Shaohua Li wrote:
> On Tue, Jun 02, 2009 at 12:58:08AM +0800, Frans Pop wrote:
> > $ git describe master
> > v2.6.30-rc7-227-gd9244b5
> >
> > [...]
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c: In
> > function ???acpi_processor_power_verify???:
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c:617
> >: error: implicit declaration of function ???acpi_timer_check_state???
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c: In
> > function ???acpi_idle_enter_c1???:
> > /home/fjp/projects/kernel/linux-2.6/drivers/acpi/processor_idle.c:839
> >: error: implicit declaration of function
> > ???acpi_state_timer_broadcast??? make[7]: ***
> > [drivers/acpi/processor_idle.o] Error 1
> >
> > Reverting the following two commits fixed the error:
> > 87ad57ba cpuidle: makes AMD C1E work in acpi_idle
> > 7d60e8ab cpuidle: fix AMD C1E suspend hang
> >
> > (Second one probably was not needed, but done as it looked related.)
>
> Can't reproduce it here with your config, can you double check please?

Ah, I'm sorry. I see what went wrong here.

For some reason I had a patch from Len that renames those functions in my 
local branch (ACPI: idle: rename lapic timer workaround routines).
Not sure when or why I picked up that patch. I've dropped it now.

Sorry for the noise and inconvenience.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/