Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758420AbZFBRlj (ORCPT ); Tue, 2 Jun 2009 13:41:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758061AbZFBRlZ (ORCPT ); Tue, 2 Jun 2009 13:41:25 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:20589 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758000AbZFBRlX (ORCPT ); Tue, 2 Jun 2009 13:41:23 -0400 Date: Tue, 2 Jun 2009 11:41:25 -0600 From: Alex Chiang To: Bjorn Helgaas Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 08/10] ACPI: simplify acpi_pci_irq_add_prt() API Message-ID: <20090602174125.GE4326@ldl.fc.hp.com> References: <20090602152351.7346.48697.stgit@bob.kio> <20090602152516.7346.24236.stgit@bob.kio> <200906021130.15951.bjorn.helgaas@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906021130.15951.bjorn.helgaas@hp.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1528 Lines: 43 * Bjorn Helgaas : > On Tuesday 02 June 2009 09:25:16 am Alex Chiang wrote: > > A PCI domain cannot change as you descend down subordinate buses, which > > makes the 'segment' argument to acpi_pci_irq_add_prt() useless. > > > > Change the interface to take a struct pci_bus *, from whence we can derive > > the bus number and segment. Reducing the number of arguments makes life > > simpler for callers. > > Nice patch. > > > diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c > > index 25ddbb6..aa67f72 100644 > > --- a/drivers/acpi/pci_root.c > > +++ b/drivers/acpi/pci_root.c > > @@ -537,8 +537,9 @@ static int __devinit acpi_pci_root_add(struct acpi_device *device) > > */ > > status = acpi_get_handle(device->handle, METHOD_NAME__PRT, &handle); > > if (ACPI_SUCCESS(status)) > > - result = acpi_pci_irq_add_prt(device->handle, root->id.segment, > > - root->id.bus); > > + result = acpi_pci_irq_add_prt(device->handle, > > + pci_find_bus(root->id.segment, > > + root->id.bus)); > > I think you can just do this: > > acpi_pci_irq_add_prt(device->handle, root->bus); Ah, indeed you are right, thanks Bjorn. Len, would you like me to respin, or can you just make the modification for me? Thanks. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/