Message-ID: <4A256462.10600@gmail.com>
Date: Tue, 02 Jun 2009 13:41:54 -0400
From: Tom Talpey <tmtalpey@gmail.com>
MIME-Version: 1.0
To: Alex Riesen <raa.lkml@gmail.com>
CC: trivial@kernel.org, linux-kernel@vger.kernel.org,
       Trond Myklebust <Trond.Myklebust@netapp.com>
Subject: Re: [PATCH] Use formatting of module name in SUNRPC
References: <20090527175955.GB8969@blimp.localdomain>
In-Reply-To: <20090527175955.GB8969@blimp.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1390
Lines: 43

On 5/27/2009 1:59 PM, Alex Riesen wrote:
> Besides, the old code caused gcc-4.3.3 to produce the warning:
>    "format not a string literal and no format arguments"
>
> Signed-off-by: Alex Riesen<raa.lkml@gmail.com>
> ---
>   net/sunrpc/xprt.c |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
> index 06ca058..82f62fd 100644
> --- a/net/sunrpc/xprt.c
> +++ b/net/sunrpc/xprt.c
> @@ -162,7 +162,6 @@ EXPORT_SYMBOL_GPL(xprt_unregister_transport);
>   int xprt_load_transport(const char *transport_name)
>   {
>   	struct xprt_class *t;
> -	char module_name[sizeof t->name + 5];
>   	int result;
>
>   	result = 0;
> @@ -174,9 +173,7 @@ int xprt_load_transport(const char *transport_name)
>   		}
>   	}
>   	spin_unlock(&xprt_list_lock);
> -	strcpy(module_name, "xprt");
> -	strncat(module_name, transport_name, sizeof t->name);
> -	result = request_module(module_name);
> +	result = request_module("xprt%s", transport_name);
>   out:
>   	return result;
>   }

Never saw the warning while compiling, but I'm fine with the
proposed change, besides, it's cleaner. Ack.

Tom.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/