Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759076AbZFBSJU (ORCPT ); Tue, 2 Jun 2009 14:09:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755552AbZFBSJM (ORCPT ); Tue, 2 Jun 2009 14:09:12 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41937 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755083AbZFBSJM (ORCPT ); Tue, 2 Jun 2009 14:09:12 -0400 Date: Tue, 2 Jun 2009 11:02:27 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: George Dunlap cc: Thomas Gleixner , David Miller , "jeremy@goop.org" , "mingo@elte.hu" , Dan Magenheimer , "avi@redhat.com" , "xen-devel@lists.xensource.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Keir Fraser , "gregkh@suse.de" , "kurt.hackel@oracle.com" , Ian Pratt , "xen-users@lists.xensource.com" , ksrinivasan , "EAnderson@novell.com" , "wimcoekaerts@wimmekes.net" , Stephen Spector , "jens.axboe@oracle.com" , "npiggin@suse.de" Subject: Re: Xen is a feature In-Reply-To: Message-ID: References: <162f4c90-6431-4a2a-b337-6d7451d7b11e@default> <20090528001350.GD26820@elte.hu> <4A1F302E.8030501@goop.org> <20090528.210559.137121893.davem@davemloft.net> <4A1FCE8E.2060604@eu.citrix.com> <4A25564A.70608@eu.citrix.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1726 Lines: 42 On Tue, 2 Jun 2009, Linus Torvalds wrote: > > I dunno. I just do know that I pointed out the statistics for how > mindlessly incestuous the Xen patches have historically been to Jeremy. He > admitted it. I've not seen _anybody_ say that things will improve. In case people want to look at this on their own, get a git tree, and run the examples I asked Jeremy to run: git log --pretty=oneline --full-diff --stat arch/x86/kvm/ | grep -v '/kvm' | less -S and then go ahead and do the same except with "xen" instead of "kvm". Now, once you've done that, ask yourself which one is going to be merged easily and without any pushback. Btw, this is NOT meant to be a "xen vs kvm" thing. Before you react to the "kvm" part, replace "arch/x86/kvm" above with "drivers/scsi" or something. The point? Xen really is horribly badly separated out. It gets way more incestuous with other systems than it should. It's entirely possible that this is very fundamental to both paravirtualization and to hypervisor behavior, but it doesn't matter - it just measn that I can well see that Xen is a f*cking pain to merge. So please, Xen people, look at your track record, and look at the issues from the standpoint of somebody merging your code, rather than just from the standpoint of somebody who whines "I want my code to be merged". IOW, if you have trouble getting your code merged, ask yourself what _you_ are doing wrong. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/