Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753576AbZFBUxC (ORCPT ); Tue, 2 Jun 2009 16:53:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752279AbZFBUwx (ORCPT ); Tue, 2 Jun 2009 16:52:53 -0400 Received: from out02.mta.xmission.com ([166.70.13.232]:35452 "EHLO out02.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbZFBUwv (ORCPT ); Tue, 2 Jun 2009 16:52:51 -0400 To: Linus Torvalds Cc: Nick Piggin , Al Viro , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Hugh Dickins , Tejun Heo , Alexey Dobriyan , Alan Cox , Greg Kroah-Hartman , Andrew Morton , Christoph Hellwig , "Eric W. Biederman" Subject: Re: [PATCH 04/23] vfs: Introduce infrastructure for revoking a file References: <1243893048-17031-4-git-send-email-ebiederm@xmission.com> <20090602071411.GE31556@wotan.suse.de> From: ebiederm@xmission.com (Eric W. Biederman) Date: Tue, 02 Jun 2009 13:52:46 -0700 In-Reply-To: (Linus Torvalds's message of "Tue\, 2 Jun 2009 10\:06\:00 -0700 \(PDT\)") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-XM-SPF: eid=;;;mid=;;;hst=in02.mta.xmission.com;;;ip=76.21.114.89;;;frm=ebiederm@xmission.com;;;spf=neutral X-SA-Exim-Connect-IP: 76.21.114.89 X-SA-Exim-Rcpt-To: torvalds@linux-foundation.org, ebiederm@aristanetworks.com, hch@infradead.org, akpm@linux-foundation.org, gregkh@suse.de, alan@lxorguk.ukuu.org.uk, adobriyan@gmail.com, tj@kernel.org, hugh@veritas.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk, npiggin@suse.de X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Version: 4.2.1 (built Thu, 25 Oct 2007 00:26:12 +0000) X-SA-Exim-Scanned: No (on in02.mta.xmission.com); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 30 Linus Torvalds writes: > On Tue, 2 Jun 2009, Nick Piggin wrote: >> >> Why is it called hotplug? Does it have anything to do with hardware? >> Because every concurrently changed software data structure in the >> kernel can be "hot"-modified, right? >> >> Wouldn't file_revoke_lock be more appropriate? > > I agree, "hotplug" just sounds crazy. It's "open" and "revoke", not > "plug" and "unplug". I guess this shows my bias in triggering this code path from pci hotunplug. Instead of with some system call. I'm not married to the name. I wanted file_lock but that is already used, and I did call the method revoke. The only place where hotplug gives a useful hint is that it makes it clear we really are disconnecting the file descriptor from what lies below it. We can't do some weird thing like keep the underlying object. Because the underlying object is gone. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/