Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753982AbZFBVsS (ORCPT ); Tue, 2 Jun 2009 17:48:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752052AbZFBVsD (ORCPT ); Tue, 2 Jun 2009 17:48:03 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:43475 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750780AbZFBVsC (ORCPT ); Tue, 2 Jun 2009 17:48:02 -0400 Date: Tue, 2 Jun 2009 17:48:03 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: "Rafael J. Wysocki" cc: Frans Pop , , , Linux Kernel Mailing List Subject: Re: [PATCH] usb: avoid PM error messages during resume if a device was disconnected In-Reply-To: <200906022326.34491.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1036 Lines: 25 On Tue, 2 Jun 2009, Rafael J. Wysocki wrote: > Returning 0 from usb_external_resume_device() if the device is not present > any more doesn't seem wrong. It's not really an error condition, IMO, because > it's rather normal that the devices may be removed while suspended. > > OTOH, I don't think we can ignore -ENODEV universally in the core, because > its meaning may depend on the bus type. For example, for PCI it sometimes > means a hardware problem has occured (other than the device being not present > any more). > I'd vote in favor of the Frans' patch, at least for now. > > So, Frans, please resubmit with the changelog modified as requested by Alan. If we change -ENODEV to 0, the change should be made in usb_resume() rather than usb_external_resume_device(). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/