Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755342AbZFCKxP (ORCPT ); Wed, 3 Jun 2009 06:53:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754059AbZFCKxA (ORCPT ); Wed, 3 Jun 2009 06:53:00 -0400 Received: from mail-fx0-f168.google.com ([209.85.220.168]:62904 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753498AbZFCKw7 (ORCPT ); Wed, 3 Jun 2009 06:52:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=n8b8H4DkbW56IQIyikBokqQJ4ejTuw3aHqWwikJjzIMUVRbHBR+IyxAngceIqwykpF TVqzwKcOj2A7kdFOAuWY8Z1aSDuE4El1Svr1tUnsFCRV5oxisasGKr15Rg9MYSoQhu0r UxaDv8zIMsGf7f+K9AtSUa+GQRYMTTRy6BIyo= MIME-Version: 1.0 In-Reply-To: References: <1240950704.3781.12.camel@maxim-laptop> <20090509171432.GA31126@liondog.tnic> <20090512060231.GB26286@liondog.tnic> <20090524192219.GA30285@liondog.tnic> <20090603073552.GA2671@liondog.tnic> Date: Wed, 3 Jun 2009 12:52:59 +0200 Message-ID: <9ea470500906030352x7d72f3c7s94b12701142a7f7a@mail.gmail.com> Subject: Re: [PATCH] Acer Aspire One Fan Control From: Borislav Petkov To: Peter Feuerer Cc: LKML , lenb@kernel.org, Matthew Garrett , Maxim Levitsky Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2760 Lines: 60 Hi, On Wed, Jun 3, 2009 at 10:10 AM, Peter Feuerer wrote: >>> Hm.. I think it should be clear that the fan is turned off, as soon as >>> the temperature is below the fanoff temperature. In my opinion printing this >>> message would be a case for a "verbose==2" verbose mode :) >> >> My reasoning was that because this is called from sysfs and the user >> sees nothing happening even if he'd turned off the fan by calling >> .set_cur_state that it might be useful to tell him why. > > But the user isn't allowed to change the fan state from userspace anymore. Actually, Pavel wanted to have that functionality... > If you try to change the fan state from userspace you'll get the "changing > fan state is not allowed" message. By the way, the system log is being polluted with that message after a suspend/resume cycle: [99027.020952] acerhdf: failed reading fan state, disabling kernelmode. [99027.520172] ACPI: EC: missing confirmations, switch off interrupt mode. [99047.672142] acerhdf: changing fan state is not allowed [99057.696151] acerhdf: changing fan state is not allowed [99067.720125] acerhdf: changing fan state is not allowed [99077.744164] acerhdf: changing fan state is not allowed [99087.796127] acerhdf: changing fan state is not allowed [99097.820147] acerhdf: changing fan state is not allowed [99107.844136] acerhdf: changing fan state is not allowed [99117.908153] acerhdf: changing fan state is not allowed [99127.932155] acerhdf: changing fan state is not allowed [99137.123893] [drm:i915_get_vblank_counter] *ERROR* trying to get vblank count for disabled pipe 0 [99137.956075] acerhdf: changing fan state is not allowed [99147.980158] acerhdf: changing fan state is not allowed [99158.004180] acerhdf: changing fan state is not allowed [99168.028148] acerhdf: changing fan state is not allowed [99170.207885] [drm:i915_get_vblank_counter] *ERROR* trying to get vblank count for disabled pipe 0 [99178.052149] acerhdf: changing fan state is not allowed [99188.076149] acerhdf: changing fan state is not allowed [99198.100148] acerhdf: changing fan state is not allowed [99208.124150] acerhdf: changing fan state is not allowed [99210.558715] acerhdf: kernelmode ON [99210.581161] acerhdf: changing fan state is not allowed because the suspend/resume cycle is causing the EC error message above. In that case, you shouldn't probably switch off kernel mode but unregister the driver completely until the EC error is fixed (if ever)... Hmm... -- Regards/Gruss, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/