Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755914AbZFCP6Z (ORCPT ); Wed, 3 Jun 2009 11:58:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753741AbZFCP6S (ORCPT ); Wed, 3 Jun 2009 11:58:18 -0400 Received: from one.firstfloor.org ([213.235.205.2]:52213 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753301AbZFCP6S (ORCPT ); Wed, 3 Jun 2009 11:58:18 -0400 Date: Wed, 3 Jun 2009 18:05:31 +0200 From: Andi Kleen To: Wu Fengguang Cc: Andi Kleen , Nick Piggin , "hugh@veritas.com" , "riel@redhat.com" , "akpm@linux-foundation.org" , "chris.mason@oracle.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH] [13/16] HWPOISON: The high level memory error handler in the VM v3 Message-ID: <20090603160531.GD1065@one.firstfloor.org> References: <200905271012.668777061@firstfloor.org> <20090527201239.C2C9C1D0294@basil.firstfloor.org> <20090528082616.GG6920@wotan.suse.de> <20090528095934.GA10678@localhost> <20090528122357.GM6920@wotan.suse.de> <20090528135428.GB16528@localhost> <20090601115046.GE5018@wotan.suse.de> <20090601183225.GS1065@one.firstfloor.org> <20090603155133.GA7529@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090603155133.GA7529@localhost> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1390 Lines: 34 On Wed, Jun 03, 2009 at 11:51:33PM +0800, Wu Fengguang wrote: > On Tue, Jun 02, 2009 at 02:32:25AM +0800, Andi Kleen wrote: > [snip] > > > > > > Clean swap cache pages can be directly isolated. A later page fault will bring > > > > > > in the known good data from disk. > > > > > > > > > > OK, but why do you ClearPageUptodate if it is just to be deleted from > > > > > swapcache anyway? > > > > > > > > The ClearPageUptodate() is kind of a careless addition, in the hope > > > > that it will stop some random readers. Need more investigations. > > > > > > OK. But it just muddies the waters in the meantime, so maybe take > > > such things out until there is a case for them. > > > > It's gone > > Andi, I'd recommend to re-add ClearPageUptodate() for dirty swap cache > pages. It will then make shmem_getpage() return EIO for > - shmem_fault() => kill app with VM_FAULT_SIGBUS > - shmem_readpage() => fail splice()/sendfile() etc. > - shmem_write_begin() => fail splice()/sendfile() etc. > which is exactly what we wanted. Note that the EIO here is permanent. Done. -Andi -- ak@linux.intel.com -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/