Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752562AbZFDEfk (ORCPT ); Thu, 4 Jun 2009 00:35:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750858AbZFDEfd (ORCPT ); Thu, 4 Jun 2009 00:35:33 -0400 Received: from TYO202.gate.nec.co.jp ([202.32.8.206]:39082 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696AbZFDEfd (ORCPT ); Thu, 4 Jun 2009 00:35:33 -0400 Date: Thu, 4 Jun 2009 13:31:38 +0900 From: Daisuke Nishimura To: KAMEZAWA Hiroyuki Cc: LKML , linux-mm , Andrew Morton , Balbir Singh , Li Zefan , Paul Menage , Daisuke Nishimura Subject: Re: [PATCH mmotm 2/2] memcg: allow mem.limit bigger than memsw.limit iff unlimited Message-Id: <20090604133138.d8286db9.nishimura@mxp.nes.nec.co.jp> In-Reply-To: <20090603174641.445e3012.kamezawa.hiroyu@jp.fujitsu.com> References: <20090603114518.301cef4d.nishimura@mxp.nes.nec.co.jp> <20090603115027.80f9169b.nishimura@mxp.nes.nec.co.jp> <20090603125228.368ecaf7.kamezawa.hiroyu@jp.fujitsu.com> <20090603140102.72b04b6f.nishimura@mxp.nes.nec.co.jp> <20090603174641.445e3012.kamezawa.hiroyu@jp.fujitsu.com> Organization: NEC Soft, Ltd. X-Mailer: Sylpheed 2.6.0 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2093 Lines: 49 On Wed, 3 Jun 2009 17:46:41 +0900, KAMEZAWA Hiroyuki wrote: > On Wed, 3 Jun 2009 14:01:02 +0900 > Daisuke Nishimura wrote: > > > On Wed, 3 Jun 2009 12:52:28 +0900, KAMEZAWA Hiroyuki wrote: > > > On Wed, 3 Jun 2009 11:50:27 +0900 > > > Daisuke Nishimura wrote: > > > > > > > Now users cannot set mem.limit bigger than memsw.limit. > > > > This patch allows mem.limit bigger than memsw.limit iff mem.limit==unlimited. > > > > > > > > By this, users can set memsw.limit without setting mem.limit. > > > > I think it's usefull if users want to limit memsw only. > > > > They must set mem.limit first and memsw.limit to the same value now for this purpose. > > > > They can save the first step by this patch. > > > > > > > > > > I don't like this. No benefits to users. > > > The user should know when they set memsw.limit they have to set memory.limit. > > > This just complicates things. > > > > > Hmm, I think there is a user who cares only limitting logical memory(mem+swap), > > not physical memory, and wants kswapd to reclaim physical memory when congested. > > At least, I'm a such user. > > > > Do you disagree even if I add a file like "memory.allow_limit_memsw_only" ? > > > > How about removing memory.limit < memsw.limit condition completely ? > It might be good idea. IMHO, there is no critical reason it must be checked by kernel, but I'm not sure. All I wanted to do was "let users who cares only about memsw.limit ignore mem.limit completely". That's why, I treated only the "unlimited"(not set mem.limit) case as special. But, as you say, there is no reason it must be implemented in kernel. (We can use a middle-ware or something.) I'll drop this and consider more. Thanks, Daisuke Nishimura. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/