Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757368AbZFDHyr (ORCPT ); Thu, 4 Jun 2009 03:54:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754166AbZFDHyk (ORCPT ); Thu, 4 Jun 2009 03:54:40 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:47511 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753405AbZFDHyk (ORCPT ); Thu, 4 Jun 2009 03:54:40 -0400 Date: Thu, 4 Jun 2009 00:54:35 -0700 From: Andrew Morton To: Mike Frysinger Cc: David Brownell , linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio sysfs: add a "toggle" value Message-Id: <20090604005435.d3671419.akpm@linux-foundation.org> In-Reply-To: <1244017019-28163-1-git-send-email-vapier@gentoo.org> References: <1244017019-28163-1-git-send-email-vapier@gentoo.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1027 Lines: 31 On Wed, 3 Jun 2009 04:16:59 -0400 Mike Frysinger wrote: > Signed-off-by: Mike Frysinger -ENOCHANGELOGAGAIN > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 51a8d41..7f79732 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -274,7 +274,12 @@ static ssize_t gpio_value_store(struct device *dev, > else { > long value; > > - status = strict_strtol(buf, 0, &value); > + if (sysfs_streq(buf, "toggle")) { > + value = !gpio_get_value_cansleep(gpio); > + status = 0; > + } else > + status = strict_strtol(buf, 0, &value); > + > if (status == 0) { > gpio_set_value_cansleep(gpio, value != 0); > status = size; A suitable place to document this is Documentation/gpio.txt. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/