Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756574AbZFDPPb (ORCPT ); Thu, 4 Jun 2009 11:15:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755019AbZFDPPT (ORCPT ); Thu, 4 Jun 2009 11:15:19 -0400 Received: from stinky.trash.net ([213.144.137.162]:34632 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752653AbZFDPPR (ORCPT ); Thu, 4 Jun 2009 11:15:17 -0400 Message-ID: <4A27E505.9070108@trash.net> Date: Thu, 04 Jun 2009 17:15:17 +0200 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Dmitry Eremin-Solenikov CC: Johannes Berg , David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, sfr@canb.auug.org.au, slapin@ossfans.org Subject: Re: [PATCH 4/6] net: add NL802154 interface for configuration of 802.15.4 devices References: <1244021629-18409-4-git-send-email-dbaryshkov@gmail.com> <1244021629-18409-5-git-send-email-dbaryshkov@gmail.com> <1244021964.10665.5.camel@johannes.local> <20090603.030911.162861804.davem@davemloft.net> <20090603105256.GB20508@doriath.ww600.siemens.net> <1244027110.1693.9.camel@johannes.local> <20090603122744.GC20508@doriath.ww600.siemens.net> <1244124749.22576.71.camel@johannes.local> <4A27E448.3040305@trash.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 686 Lines: 17 Dmitry Eremin-Solenikov wrote: > 2009/6/4 Patrick McHardy : >> canceling messages is only necessary in fill functions that are >> also used for dumps, where as many elements are stuffed in the >> skb as possible. When the last element doesn't completely fit, >> its removed again (canceled) and put into the next skb. > > Understood. So you'd suggest just to drop the genlmsg_cancel() > from the failure call chain? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/