Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbZFDWm1 (ORCPT ); Thu, 4 Jun 2009 18:42:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752782AbZFDWmQ (ORCPT ); Thu, 4 Jun 2009 18:42:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40345 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752331AbZFDWmP (ORCPT ); Thu, 4 Jun 2009 18:42:15 -0400 Date: Thu, 4 Jun 2009 15:41:42 -0700 From: Andrew Morton To: Florian Fainelli Cc: sshtylyov@ru.mvista.com, davem@davemloft.net, netdev@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, tiwai@suse.de, ralf@linux-mips.org Subject: Re: [PATCH 1/8] add lib/gcd.c Message-Id: <20090604154142.71985f17.akpm@linux-foundation.org> In-Reply-To: <200906041639.04868.florian@openwrt.org> References: <200906041615.10467.florian@openwrt.org> <4A27DAAD.5000303@ru.mvista.com> <200906041639.04868.florian@openwrt.org> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2756 Lines: 100 On Thu, 4 Jun 2009 16:39:03 +0200 Florian Fainelli wrote: > This patch adds lib/gcd.c which contains a greatest > common divider implementation taken from > sound/core/pcm_timer.c > > Changes from v1: > - fixed indentation > - use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL as > suggested by Ralf Baechle I'm not sure about the _GPL change really - it's just a little helper function. But whatever - I'm trained to avoid that issue. I made some changes: From: Andrew Morton - use swap() (pointed out by Joe) - Just add gcd.o to lib-y, reove Kconfig changes. Cc: David S. Miller Cc: Florian Fainelli Cc: Julius Volz Cc: Sergei Shtylyov Cc: Simon Horman Cc: Takashi Iwai Cc: Joe Perches Signed-off-by: Andrew Morton --- lib/Kconfig | 3 --- lib/Makefile | 3 +-- lib/gcd.c | 8 +++----- 3 files changed, 4 insertions(+), 10 deletions(-) diff -puN lib/Kconfig~lib-add-lib-gcdc-fix lib/Kconfig --- a/lib/Kconfig~lib-add-lib-gcdc-fix +++ a/lib/Kconfig @@ -10,9 +10,6 @@ menu "Library routines" config BITREVERSE tristate -config GCD - bool - config GENERIC_FIND_FIRST_BIT bool diff -puN lib/Makefile~lib-add-lib-gcdc-fix lib/Makefile --- a/lib/Makefile~lib-add-lib-gcdc-fix +++ a/lib/Makefile @@ -12,7 +12,7 @@ lib-y := ctype.o string.o vsprintf.o cmd idr.o int_sqrt.o extable.o prio_tree.o \ sha1.o irq_regs.o reciprocal_div.o argv_split.o \ proportions.o prio_heap.o ratelimit.o show_mem.o \ - is_single_threaded.o plist.o decompress.o + is_single_threaded.o plist.o decompress.o gcd.o lib-$(CONFIG_MMU) += ioremap.o lib-$(CONFIG_SMP) += cpumask.o @@ -57,7 +57,6 @@ obj-$(CONFIG_CRC_ITU_T) += crc-itu-t.o obj-$(CONFIG_CRC32) += crc32.o obj-$(CONFIG_CRC7) += crc7.o obj-$(CONFIG_LIBCRC32C) += libcrc32c.o -obj-$(CONFIG_GCD) += gcd.o obj-$(CONFIG_GENERIC_ALLOCATOR) += genalloc.o obj-$(CONFIG_ZLIB_INFLATE) += zlib_inflate/ diff -puN lib/gcd.c~lib-add-lib-gcdc-fix lib/gcd.c --- a/lib/gcd.c~lib-add-lib-gcdc-fix +++ a/lib/gcd.c @@ -1,3 +1,4 @@ +#include #include #include @@ -6,11 +7,8 @@ unsigned long gcd(unsigned long a, unsig { unsigned long r; - if (a < b) { - r = a; - a = b; - b = r; - } + if (a < b) + swap(a, b); while ((r = a % b) != 0) { a = b; b = r; _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/