Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbZFDWws (ORCPT ); Thu, 4 Jun 2009 18:52:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752168AbZFDWwk (ORCPT ); Thu, 4 Jun 2009 18:52:40 -0400 Received: from mga05.intel.com ([192.55.52.89]:6278 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751860AbZFDWwk (ORCPT ); Thu, 4 Jun 2009 18:52:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.41,307,1241420400"; d="scan'208";a="463657858" Date: Fri, 5 Jun 2009 00:54:49 +0200 From: Samuel Ortiz To: Daniel Ribeiro Cc: Geert Uytterhoeven , linux-kernel , Harald Welte , Philipp Zabel , openezx-devel , linux-next Subject: Re: [PATCH v3] MFD: PCAP driver Message-ID: <20090604225447.GA4806@sortiz.org> References: <1243399356.2263.46.camel@brutus> <10f740e80906030738x3b42de18n189367b28a730c56@mail.gmail.com> <1244074856.4767.26.camel@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1244074856.4767.26.camel@brutus> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1327 Lines: 50 Hi Daniel, On Wed, Jun 03, 2009 at 09:20:56PM -0300, Daniel Ribeiro wrote: > Em Qua, 2009-06-03 ?s 16:38 +0200, Geert Uytterhoeven escreveu: > > > +config EZX_PCAP > > > + bool "PCAP Support" > > > + depends on SPI_MASTER > > > > It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type(): > > Hi Geert, sorry for this. :) > > > > Fix EZX_PCAP dependency > > Signed-off-by: Daniel Ribeiro Thanks. Pushed to my for-next branch. I fixed it on the original patch, to avoid having 2 commits. Cheers, Samuel. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 060ee14..6557d60 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -243,7 +243,7 @@ config PCF50633_GPIO > > config EZX_PCAP > bool "PCAP Support" > - depends on SPI_MASTER > + depends on GENERIC_HARDIRQS && SPI_MASTER > help > This enables the PCAP ASIC present on EZX Phones. This is > needed for MMC, TouchScreen, Sound, USB, etc.. > > -- > Daniel Ribeiro > -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/