Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbZFDX1u (ORCPT ); Thu, 4 Jun 2009 19:27:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752139AbZFDX1n (ORCPT ); Thu, 4 Jun 2009 19:27:43 -0400 Received: from mx-out2.daemonmail.net ([216.104.160.39]:34950 "EHLO mx-out2.daemonmail.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751798AbZFDX1m (ORCPT ); Thu, 4 Jun 2009 19:27:42 -0400 From: "Michael S. Zick" Reply-To: lkml@morethan.org To: Dave Jones Subject: Re: Linux 2.6.30-rc8 [also: VIA Support] Date: Thu, 4 Jun 2009 18:26:40 -0500 User-Agent: KMail/1.9.9 Cc: Harald Welte , Linus Torvalds , Duane Griffin , Linux Kernel Mailing List References: <20090604214301.GB20822@redhat.com> <200906041700.17852.lkml@morethan.org> In-Reply-To: <200906041700.17852.lkml@morethan.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906041826.42856.lkml@morethan.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2376 Lines: 69 On Thu June 4 2009, Michael S. Zick wrote: > On Thu June 4 2009, Dave Jones wrote: > > On Thu, Jun 04, 2009 at 04:38:13PM -0500, Michael S. Zick wrote: > I have it now, you where speaking of the "product vendor Centaur" not a specific model name "Centaur". Which I translate into: that statement block needs to be converted into (possibly nested) switch statement(s). Since there is not a "model check" in it only a "Series" and "Vendor" check. Yuck. Mike > > > I have already preceded that chunk of code with a printk and confirmed > > > that x86_clflush_size is properly set to 64 bytes (somewhere else). > > > > > > So your suggestion is the obvious one for the C7-M, > > > I don't know about any other makes/models. > > > > > > This machine's C7-M is being reported as a "stepping 0" ?? > > > What is earlier than a stepping 0 ?? > > > > Earlier model numbers. > > (Stepping gets reset to 0 every time they bump the model) > > > > So 6.model=13.stepping=0 should do it for the (or this) C7-M, correct? > Your mention of "earlier models" will not apply until there is a > stepping >0 for a model=13, correct? > > Would a good practice be to put a "WARN_ON" in there in case a stepping > greater than =0 happens to execute the code? > In addition to checking specificly for 6.13.0 (rather than just 6.13). > > Hmmm... > But that is making a big mess of a small mess - > Why not just do the assignment you suggest for 6.model>=13? > > Models earlier than 13 are evidently working (due to lack of > bug reports or other noise on this list). > > Mike > > Dave > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/