Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754488AbZFECMT (ORCPT ); Thu, 4 Jun 2009 22:12:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752292AbZFECMI (ORCPT ); Thu, 4 Jun 2009 22:12:08 -0400 Received: from mx2.redhat.com ([66.187.237.31]:60724 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbZFECMH (ORCPT ); Thu, 4 Jun 2009 22:12:07 -0400 Date: Thu, 4 Jun 2009 22:12:01 -0400 From: Amerigo Wang To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, sam@ravnborg.org, Amerigo Wang , linux-kbuild@vger.kernel.org Message-Id: <20090605021419.7905.89870.sendpatchset@localhost.localdomain> Subject: [Patch] kbuild: fix headers_check.pl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1557 Lines: 53 'extern' checking information is not clear, refine it. Plus, fix a comment. Signed-off-by: WANG Cong Cc: Sam Ravnborg ---- diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 56f90a4..3923888 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -2,7 +2,7 @@ # # headers_check.pl execute a number of trivial consistency checks # -# Usage: headers_check.pl dir [files...] +# Usage: headers_check.pl dir arch [files...] # dir: dir to look for included files # arch: architecture # files: list of files to check @@ -37,7 +37,7 @@ foreach my $file (@files) { &check_include(); &check_asm_types(); &check_sizetypes(); - &check_prototypes(); + &check_declarations(); # Dropped for now. Too much noise &check_config(); } close FH; @@ -61,10 +61,14 @@ sub check_include } } -sub check_prototypes +sub check_declarations { - if ($line =~ m/^\s*extern\b/) { - printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + if ($line =~m/^\s*extern\b/) { + if ($line =~ m/^\s*extern\b.*\(.*\)/) { + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + } else { + printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n"; + } } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/