Date: Thu, 4 Jun 2009 21:13:50 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
       jason.wessel@windriver.com, kgdb-bugreport@lists.sourceforge.net,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kgdbts: unify/generalize gdb breakpoint adjustment
Message-Id: <20090604211350.9aafa731.akpm@linux-foundation.org>
In-Reply-To: <8bd0f97a0906042100j9a44f95g7d05a515725c9d5@mail.gmail.com>
References: <1243927050-30685-1-git-send-email-vapier@gentoo.org>
	<20090604175030.55cc4a68.akpm@linux-foundation.org>
	<8bd0f97a0906041755q7588ba76l1e4e1eb8bdbe336@mail.gmail.com>
	<20090604180420.2805fcdd.akpm@linux-foundation.org>
	<8bd0f97a0906041850v4a41082fkf9726ae1bdd299cb@mail.gmail.com>
	<20090604192723.36874fcb.akpm@linux-foundation.org>
	<8bd0f97a0906042100j9a44f95g7d05a515725c9d5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1651
Lines: 57

On Fri, 5 Jun 2009 00:00:22 -0400 Mike Frysinger <vapier.adi@gmail.com> wrote:

> your version after all requires every arch to copy & paste this crap:
> static inline unsigned long instruction_pointer(struct pt_regs *regs)
> {
>     return regs->ip;
> }
> static inline void instruction_pointer_set(struct pt_regs *regs,
> unsigned long val)
> {
>     regs->ip = val;
> }
> 
> and then actual usage turns into:
> instruction_pointer_set(regs, instruction_pointer(regs) + foo);
> 
> whereas mine is two lines:
> #define instruction_pointer(regs) ((regs)->ip)
> instruction_pointer(regs) += val;

The aim isn't really to reduce the amount of typing one needs to do. 
Let's get things right, and if getting it right involves more typing
then so be it.


If it really worries you then you could do

#define GET_IP(regs)	((regs)->ip)
#include <asm/generic/instruction_pointer.h>

and

static inline unsigned long instruction_pointer(struct pt_regs *regs)
{
	return GET_IP(regs);
}

static inline void instruction_pointer_set(struct pt_regs *regs,
					unsigned long val)
{
	GET_IP(regs) = val;
}

Note that GET_IP() is all-caps, which says "this is a macro".

But I don't think it's worth the ickyness, unless we also incorporate
kernel_stack_pointer(), frame_pointer(), user_stack_pointer() and
perhaps the _set() versions of those also.


Do we know how to implement instruction_pointer_set() on ia64, btw?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/