Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbZFEMGR (ORCPT ); Fri, 5 Jun 2009 08:06:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751302AbZFEMGE (ORCPT ); Fri, 5 Jun 2009 08:06:04 -0400 Received: from h5.dl5rb.org.uk ([81.2.74.5]:60919 "EHLO h5.dl5rb.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751024AbZFEMGE (ORCPT ); Fri, 5 Jun 2009 08:06:04 -0400 Date: Fri, 5 Jun 2009 13:04:15 +0100 From: Ralf Baechle To: Arnd Bergmann Cc: Sam Ravnborg , Jaswinder Singh Rajput , Ingo Molnar , Andrew Morton , LKML , linux-mips , Michael Abbott Subject: Re: [PATCH 4/6] headers_check fix: mips, ioctl.h Message-ID: <20090605120414.GB23433@linux-mips.org> References: <1244118232.5172.26.camel@ht.satnam> <20090604124631.GB19459@linux-mips.org> <20090604200953.GA13892@uranus.ravnborg.org> <200906051034.01817.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906051034.01817.arnd@arndb.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 47 On Fri, Jun 05, 2009 at 10:34:00AM +0100, Arnd Bergmann wrote: > On Thursday 04 June 2009, Sam Ravnborg wrote: > > Any specific reason why mips does not use include/asm-generic/ioctl.h? > > Had mips done so this would not have been an issue. > > The original include/asm-generic/ioctl.h did not allow overriding > the values of _IOC_{SIZEBITS,DIRBITS,NONE,READ,WRITE}, so it > was initially not possible to use it. > > Nowadays, you can simply use the same approach as powerpc: > > #ifndef _ASM_MIPS_IOCTL_H > #define _ASM_MIPS_IOCTL_H > > #define _IOC_SIZEBITS 13 > #define _IOC_DIRBITS 3 > > #define _IOC_NONE 1U > #define _IOC_READ 2U > #define _IOC_WRITE 4U > > /* > * The following are included for compatibility > */ > #define _IOC_VOID 0x20000000 > #define _IOC_OUT 0x40000000 > #define _IOC_IN 0x80000000 > #define _IOC_INOUT (IOC_IN|IOC_OUT) > > #include > > #endif /* _ASM_MIPS_IOCTL_H */ > > This would indeed be a cleaner fix. In fact that's almost identical to what I already have. But I don't even recall what _IOC_VOID, _IOC_OUT, _IOC_IN and _IOC_INOUT were meant to be compatible with. They were added in 2.1.14 so presumably they've become irrlevant, so I've dropped them. I bet nobody will notice. Ralf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/