Return-Path: <linux-kernel-owner+w=401wt.eu-S1755837AbZFEQHi@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755837AbZFEQHi (ORCPT <rfc822;w@1wt.eu>);
	Fri, 5 Jun 2009 12:07:38 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751302AbZFEQHb
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 5 Jun 2009 12:07:31 -0400
Received: from 136-022.dsl.LABridge.com ([206.117.136.22]:4120 "EHLO
	mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751079AbZFEQHa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 5 Jun 2009 12:07:30 -0400
Subject: Re: [PATCH] eeepc-laptop.c: use pr_fmt and pr_<level>
From: Joe Perches <joe@perches.com>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
       acpi4asus-user@lists.sourceforge.net,
       LKML <linux-kernel@vger.kernel.org>, Len Brown <len.brown@intel.com>,
       Matthew Garrett <mjg@redhat.com>,
       Darren Salt <linux@youmustbejoking.demon.co.uk>
In-Reply-To: <71cd59b00906050901p71c7483fja5b3c74744f93384@mail.gmail.com>
References: <1244197103.3631.40.camel@Joe-Laptop.home>
	 <4A28F94A.6040500@tuffmail.co.uk>
	 <1244199633.3631.43.camel@Joe-Laptop.home>
	 <71cd59b00906050457i29638577o9eeb5e8fa8eb087c@mail.gmail.com>
	 <1244216712.3631.117.camel@Joe-Laptop.home>
	 <71cd59b00906050901p71c7483fja5b3c74744f93384@mail.gmail.com>
Content-Type: text/plain
Date: Fri, 05 Jun 2009 09:07:22 -0700
Message-Id: <1244218042.3631.158.camel@Joe-Laptop.home>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1461
Lines: 31

On Fri, 2009-06-05 at 18:01 +0200, Corentin Chary wrote:
> On Fri, Jun 5, 2009 at 5:45 PM, Joe Perches<joe@perches.com> wrote:
> > On Fri, 2009-06-05 at 13:57 +0200, Corentin Chary wrote:
> >> On Fri, Jun 5, 2009 at 1:00 PM, Joe Perches<joe@perches.com> wrote:
> >> > On Fri, 2009-06-05 at 11:54 +0100, Alan Jenkins wrote:
> >> >> Is EEEPC_HOTK_FILE used anywhere else?  It would be clearer if you were
> >> >> able to just use "eeepc: " or whatever and remove the definition of
> >> >> EEEPC_HOTK_FILE.
> >> > It is used elsewhere and perhaps it'd be better to use KBUILD_MODNAME.
> >> I think we can't use KBUILD_MODNAME because "eeepc" is used for
> >> platform_device, backlight and input device. Using "eeepc-laptop"
> >> would break compatibility.
> > What compatibility would it break?
> > Logging messages are not guaranteed to be stable across versions.
> for platform_device backlight and input device it would change the
> "/sys" paths (eg: /sys/class/backlight/eeepc)

I see what you mean.  We're talking cross purposes though.
I meant that KBUILD_MODNAME be used for pr_fmt, not anywhere else.

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

So, no changes to any other EEPC_HOTK_FILE uses.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/