Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753AbZFEUEM (ORCPT ); Fri, 5 Jun 2009 16:04:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752270AbZFEUD7 (ORCPT ); Fri, 5 Jun 2009 16:03:59 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]:43003 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752151AbZFEUD6 (ORCPT ); Fri, 5 Jun 2009 16:03:58 -0400 Message-ID: <4A297A25.6010402@free.fr> Date: Fri, 05 Jun 2009 22:03:49 +0200 From: matthieu castet User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.19) Gecko/20081204 Iceape/1.1.14 (Debian-1.1.14-1) MIME-Version: 1.0 To: Andrew Morton CC: wim@iguana.be, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, biblbroks@sezampro.rs Subject: Re: add bcm47xx watchdog driver References: <4A282D98.6020004@free.fr> <20090605125023.d968c58e.akpm@linux-foundation.org> In-Reply-To: <20090605125023.d968c58e.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1210 Lines: 36 Andrew Morton wrote: > On Thu, 04 Jun 2009 22:24:56 +0200 > matthieu castet wrote: > >> This add watchdog driver for broadcom 47xx device. >> It uses the ssb subsytem to access embeded watchdog device. >> >> ... >> >> --- linux-2.6.orig/drivers/watchdog/Kconfig 2009-05-25 22:22:02.000000000 +0200 >> +++ linux-2.6/drivers/watchdog/Kconfig 2009-05-25 22:26:06.000000000 +0200 >> @@ -764,6 +764,12 @@ >> help >> Hardware driver for the built-in watchdog timer on TXx9 MIPS SoCs. >> >> +config BCM47XX_WDT >> + tristate "Broadcom BCM47xx Watchdog Timer" >> + depends on BCM47XX >> + help >> + Hardware driver for the Broadcom BCM47xx Watchog Timer. > > Shouldn't there be some SSB dependencies in Kconfig here? No, because : config BCM47XX bool "BCM47XX based boards" [...] select SSB select SSB_DRIVER_MIPS select SSB_DRIVER_EXTIF select SSB_EMBEDDED select SSB_PCICORE_HOSTMODE if PCI -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/