Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757379AbZFEXrR (ORCPT ); Fri, 5 Jun 2009 19:47:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756176AbZFEXlu (ORCPT ); Fri, 5 Jun 2009 19:41:50 -0400 Received: from pfepa.post.tele.dk ([195.41.46.235]:45067 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755253AbZFEXlN (ORCPT ); Fri, 5 Jun 2009 19:41:13 -0400 From: Sam Ravnborg To: linux-kbuild , LKML Cc: "Robert P. J. Day" , David Woodhouse , Andrew Morton , Sam Ravnborg Subject: [PATCH 34/39] scripts/headers_check.pl: correct RE in header CONFIG leak check Date: Sat, 6 Jun 2009 01:42:52 +0200 Message-Id: <1244245377-17441-34-git-send-email-sam@ravnborg.org> X-Mailer: git-send-email 1.6.3.rc3.40.g75b44 In-Reply-To: <20090605233720.GA13588@uranus.ravnborg.org> References: <20090605233720.GA13588@uranus.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1822 Lines: 49 From: Robert P. J. Day Correct the regular expression in scripts/headers_check.pl to include '_' as a valid character in the class; otherwise, the check will report a "leaked" symbol of CONFIG_A_B_C as merely CONFIG_A. This patch will make no difference whatsoever in the current kernel tree as the call to the perl routine that does that check is currently commented out: &check_include(); &check_asm_types(); &check_sizetypes(); &check_prototypes(); # Dropped for now. Too much noise &check_config(); However, I noticed that problem when I was building the yum downloadable kernel source rpm for fedora 11 (beta), which *does* run that check, and that's where the problem became obvious. Signed-off-by: Robert P. J. Day Cc: David Woodhouse Signed-off-by: Andrew Morton Signed-off-by: Sam Ravnborg --- scripts/headers_check.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 3923888..e3fb949 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -74,7 +74,7 @@ sub check_declarations sub check_config { - if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9]+)[^a-zA-Z0-9]/) { + if ($line =~ m/[^a-zA-Z0-9_]+CONFIG_([a-zA-Z0-9_]+)[^a-zA-Z0-9_]/) { printf STDERR "$filename:$lineno: leaks CONFIG_$1 to userspace where it is not valid\n"; } } -- 1.6.3.rc3.40.g75b44 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/