Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756606AbZFEXte (ORCPT ); Fri, 5 Jun 2009 19:49:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756194AbZFEXmB (ORCPT ); Fri, 5 Jun 2009 19:42:01 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:36411 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754295AbZFEXlL (ORCPT ); Fri, 5 Jun 2009 19:41:11 -0400 From: Sam Ravnborg To: linux-kbuild , LKML Cc: Amerigo Wang , Sam Ravnborg Subject: [PATCH 18/39] kbuild/headers_check: refine extern check Date: Sat, 6 Jun 2009 01:42:36 +0200 Message-Id: <1244245377-17441-18-git-send-email-sam@ravnborg.org> X-Mailer: git-send-email 1.6.3.rc3.40.g75b44 In-Reply-To: <20090605233720.GA13588@uranus.ravnborg.org> References: <20090605233720.GA13588@uranus.ravnborg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1729 Lines: 59 From: Amerigo Wang 'extern' checking information is not clear, refine it. Plus, fix a comment. Signed-off-by: WANG Cong Signed-off-by: Sam Ravnborg --- scripts/headers_check.pl | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-) diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 56f90a4..3923888 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -2,7 +2,7 @@ # # headers_check.pl execute a number of trivial consistency checks # -# Usage: headers_check.pl dir [files...] +# Usage: headers_check.pl dir arch [files...] # dir: dir to look for included files # arch: architecture # files: list of files to check @@ -37,7 +37,7 @@ foreach my $file (@files) { &check_include(); &check_asm_types(); &check_sizetypes(); - &check_prototypes(); + &check_declarations(); # Dropped for now. Too much noise &check_config(); } close FH; @@ -61,10 +61,14 @@ sub check_include } } -sub check_prototypes +sub check_declarations { - if ($line =~ m/^\s*extern\b/) { - printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + if ($line =~m/^\s*extern\b/) { + if ($line =~ m/^\s*extern\b.*\(.*\)/) { + printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + } else { + printf STDERR "$filename:$lineno: exporting global variable to userspace is suspicious\n"; + } } } -- 1.6.3.rc3.40.g75b44 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/