Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754240AbZFFIgi (ORCPT ); Sat, 6 Jun 2009 04:36:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752935AbZFFIg3 (ORCPT ); Sat, 6 Jun 2009 04:36:29 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:45614 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752555AbZFFIg2 (ORCPT ); Sat, 6 Jun 2009 04:36:28 -0400 Date: Sat, 6 Jun 2009 10:38:44 +0200 From: Sam Ravnborg To: Arnd Bergmann Cc: linux-kbuild , LKML , Amerigo Wang Subject: Re: [PATCH 18/39] kbuild/headers_check: refine extern check Message-ID: <20090606083844.GA14555@uranus.ravnborg.org> References: <20090605233720.GA13588@uranus.ravnborg.org> <1244245377-17441-18-git-send-email-sam@ravnborg.org> <200906060046.07421.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906060046.07421.arnd@arndb.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2118 Lines: 68 On Sat, Jun 06, 2009 at 12:46:07AM +0000, Arnd Bergmann wrote: > On Friday 05 June 2009 11:42:36 pm Sam Ravnborg wrote: > > From: Amerigo Wang > > > > 'extern' checking information is not clear, refine it. > > Plus, fix a comment. > > > > Signed-off-by: WANG Cong > > Signed-off-by: Sam Ravnborg > > I still think this is pointless and should just be removed > (or replaced with a patch to kill the apostrophe in there). So you wanted me to visit that link... I redid it like this: Subject: kbuild/headers_check: refine extern check 'extern' checking information is not clear, refine it. Plus, fix a comment. Signed-off-by: WANG Cong [sam: redid the extern error message] Signed-off-by: Sam Ravnborg --- diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl index 4414c43..db1dd7a 100644 --- a/scripts/headers_check.pl +++ b/scripts/headers_check.pl @@ -2,7 +2,7 @@ # # headers_check.pl execute a number of trivial consistency checks # -# Usage: headers_check.pl dir [files...] +# Usage: headers_check.pl dir arch [files...] # dir: dir to look for included files # arch: architecture # files: list of files to check @@ -37,7 +37,7 @@ foreach my $file (@files) { &check_include(); &check_asm_types(); &check_sizetypes(); - &check_prototypes(); + &check_declarations(); # Dropped for now. Too much noise &check_config(); } close FH; @@ -61,10 +61,12 @@ sub check_include } } -sub check_prototypes +sub check_declarations { - if ($line =~ m/^\s*extern\b/) { - printf STDERR "$filename:$lineno: extern's make no sense in userspace\n"; + if ($line =~m/^\s*extern\b/) { + printf STDERR "$filename:$lineno: " . + "userspace cannot call function or variable " . + "defined in the kernel\n"; } } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/