Date: Sun, 7 Jun 2009 16:01:13 +0200
From: Ingo Molnar <mingo@elte.hu>
To: "Figo.zhang" <figo1802@gmail.com>,
       Dmitry Adamushko <dmitry.adamushko@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, Tigran Aivazian <tigran@veritas.com>,
       lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]X86:microcode: fix vfree()
Message-ID: <20090607140113.GI12088@elte.hu>
References: <1244351929.3355.13.camel@myhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1244351929.3355.13.camel@myhost>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 668
Lines: 33


* Figo.zhang <figo1802@gmail.com> wrote:

>  
> vfree() does it's own 'NULL' check,so no need for check before
> calling it.

looks good, but:

 s/it's/its/
 s/check,so/check, so/

and:

>  static void free_equiv_cpu_table(void)
>  {
> -	if (equiv_cpu_table) {
> -		vfree(equiv_cpu_table);
> -		equiv_cpu_table = NULL;
> -	}
> +	vfree(equiv_cpu_table);
> +	equiv_cpu_table = NULL;
> +	
>  }

stray newline and tab.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/