Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbZFGPeG (ORCPT ); Sun, 7 Jun 2009 11:34:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752812AbZFGPdz (ORCPT ); Sun, 7 Jun 2009 11:33:55 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:50395 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752782AbZFGPdz (ORCPT ); Sun, 7 Jun 2009 11:33:55 -0400 Date: Sun, 7 Jun 2009 17:33:27 +0200 From: Ingo Molnar To: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, andreas.herrmann3@amd.com, stable@kernel.org, tglx@linutronix.de Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:x86/urgent] x86: Detect use of extended APIC ID for AMD CPUs Message-ID: <20090607153327.GA8973@elte.hu> References: <20090604104016.GT5736@alberich.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0013] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 23 * tip-bot for Andreas Herrmann wrote: > +#ifdef CONFIG_X86_LOCAL_APIC > + /* check CPU config space for extended APIC ID */ > + if (c->x86 >= 0xf) { > + unsigned int val; > + > + val = read_pci_config(0, 24, 0, 0x68); > + if ((val & ((1 << 17) | (1 << 18))) == ((1 << 17) | (1 << 18))) > + set_cpu_cap(c, X86_FEATURE_EXTD_APICID); > + } > +#endif It's possible to enable local APIC but not CONFIG_PCI - in that case this sequence will fail to build. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/