Subject: Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as
 per-CPU ring buffer
From: Huang Ying <ying.huang@intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       Andi Kleen <ak@linux.intel.com>,
       Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
In-Reply-To: <20090608072030.GA6732@elte.hu>
References: <1244445115.8361.576.camel@yhuang-dev.sh.intel.com>
	 <20090608072030.GA6732@elte.hu>
Content-Type: text/plain
Date: Mon, 08 Jun 2009 15:30:22 +0800
Message-Id: <1244446222.8361.584.camel@yhuang-dev.sh.intel.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 855
Lines: 24

On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote:
> * Huang Ying <ying.huang@intel.com> wrote:
> 
> > Re-implement MCE log ring buffer as per-CPU ring buffer for better 
> > scalability.
> 
> this should be done using the generic ring-buffer code - see 
> include/linux/ring_buffer.h. Having a private implementation in 
> architecture code is not really acceptable.

MCE log ring buffer need to be NMI-safe, while current generic
ring-buffer code is not NMI safe. Maybe we can use the generic
ring-buffer code after it goes NMI-safe. But for now, I think this patch
is better.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/