Date: Mon, 8 Jun 2009 09:38:45 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Huang Ying <ying.huang@intel.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       Andi Kleen <ak@linux.intel.com>,
       Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as
	per-CPU ring buffer
Message-ID: <20090608073845.GA32745@elte.hu>
References: <1244445115.8361.576.camel@yhuang-dev.sh.intel.com> <20090608072030.GA6732@elte.hu> <1244446222.8361.584.camel@yhuang-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1244446222.8361.584.camel@yhuang-dev.sh.intel.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1058
Lines: 27


* Huang Ying <ying.huang@intel.com> wrote:

> On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote:
> > * Huang Ying <ying.huang@intel.com> wrote:
> > 
> > > Re-implement MCE log ring buffer as per-CPU ring buffer for better 
> > > scalability.
> > 
> > this should be done using the generic ring-buffer code - see 
> > include/linux/ring_buffer.h. Having a private implementation in 
> > architecture code is not really acceptable.
> 
> MCE log ring buffer need to be NMI-safe, while current generic 
> ring-buffer code is not NMI safe. [...]

Then please work with Steve to make it NMI safe (or do so yourself) 
- i've Cc:-ed him - that way we help the core kernel: one of its 
essential facilities will get one more user. We dont put private, 
open-coded ring-buffer facilities into architecture code.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/