Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471AbZFHI0u (ORCPT ); Mon, 8 Jun 2009 04:26:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753321AbZFHI0n (ORCPT ); Mon, 8 Jun 2009 04:26:43 -0400 Received: from mga02.intel.com ([134.134.136.20]:6239 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752953AbZFHI0m (ORCPT ); Mon, 8 Jun 2009 04:26:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.41,323,1241420400"; d="scan'208";a="522567753" Subject: Re: [PATCH -v5] x86: MCE: Re-implement MCE log ring buffer as per-CPU ring buffer From: Huang Ying To: Ingo Molnar Cc: Steven Rostedt , "H. Peter Anvin" , Thomas Gleixner , Andi Kleen , Hidetoshi Seto , "linux-kernel@vger.kernel.org" In-Reply-To: <20090608073845.GA32745@elte.hu> References: <1244445115.8361.576.camel@yhuang-dev.sh.intel.com> <20090608072030.GA6732@elte.hu> <1244446222.8361.584.camel@yhuang-dev.sh.intel.com> <20090608073845.GA32745@elte.hu> Content-Type: text/plain Date: Mon, 08 Jun 2009 16:26:42 +0800 Message-Id: <1244449602.8361.587.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 33 On Mon, 2009-06-08 at 15:38 +0800, Ingo Molnar wrote: > * Huang Ying wrote: > > > On Mon, 2009-06-08 at 15:20 +0800, Ingo Molnar wrote: > > > * Huang Ying wrote: > > > > > > > Re-implement MCE log ring buffer as per-CPU ring buffer for better > > > > scalability. > > > > > > this should be done using the generic ring-buffer code - see > > > include/linux/ring_buffer.h. Having a private implementation in > > > architecture code is not really acceptable. > > > > MCE log ring buffer need to be NMI-safe, while current generic > > ring-buffer code is not NMI safe. [...] > > Then please work with Steve to make it NMI safe (or do so yourself) > - i've Cc:-ed him - that way we help the core kernel: one of its > essential facilities will get one more user. We dont put private, > open-coded ring-buffer facilities into architecture code. Steve have said he has a NMI-safe solution, but it is under patent application. It seems that patent application will take very long time, so we decide to enhance mce log buffer instead of waiting. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/