Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbZFHKqA (ORCPT ); Mon, 8 Jun 2009 06:46:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753814AbZFHKpu (ORCPT ); Mon, 8 Jun 2009 06:45:50 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:40011 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753353AbZFHKpu (ORCPT ); Mon, 8 Jun 2009 06:45:50 -0400 Date: Mon, 8 Jun 2009 06:45:44 -0400 From: Christoph Hellwig To: Wu Fengguang Cc: Artem Bityutskiy , Jan Kara , Eric Sandeen , Andrew Morton , LKML , Masayoshi MIZUMA , "linux-fsdevel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , Nick Piggin , Jeff Layton Subject: Re: [PATCH] writeback: skip new or to-be-freed inodes Message-ID: <20090608104544.GA2428@infradead.org> References: <20090324124001.GA25326@localhost> <4A244A5B.7070605@sandeen.net> <20090602085523.GC7161@localhost> <20090602113736.GB15010@duck.suse.cz> <20090603141021.GB5738@localhost> <20090603141636.GC5650@duck.suse.cz> <20090603144711.GC5738@localhost> <20090606030725.GA12852@localhost> <4A2CB7AE.6080909@gmail.com> <20090608092930.GA13846@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090608092930.GA13846@localhost> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 16 On Mon, Jun 08, 2009 at 05:29:30PM +0800, Wu Fengguang wrote: > Thank you. Basically I'm not sure if UBIFS guarantees it won't be > unmounted (hence the MS_ACTIVE bit is on) when calling > generic_sync_sb_inodes() in shrink_liability() and ubifs_sync_fs(). Btw, the call in ubifs_sync_fs should be superflous in the vfs-2.6#for-next tree. We now do make sure that all inodes are flushed before calling ->sync_fs with the wait parameter. shrink_liability is a more interesting case, I don't understand enough of ubifs to comment on it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/