Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755615AbZFHQ1Z (ORCPT ); Mon, 8 Jun 2009 12:27:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753958AbZFHQ1G (ORCPT ); Mon, 8 Jun 2009 12:27:06 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:54233 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757006AbZFHQ1E (ORCPT ); Mon, 8 Jun 2009 12:27:04 -0400 Date: Mon, 8 Jun 2009 09:26:56 -0700 From: "Paul E. McKenney" To: Jesper Dangaard Brouer Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de, wg@grandegger.com, vladislav.yasevich@hp.com, sri@us.ibm.com, linux-sctp@vger.kernel.org, Trond.Myklebust@netapp.com, linux-nfs@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module unload. Message-ID: <20090608162656.GF6961@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20090608130959.10052.54590.stgit@localhost> <20090608131148.10052.39869.stgit@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090608131148.10052.39869.stgit@localhost> User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1239 Lines: 34 On Mon, Jun 08, 2009 at 03:11:48PM +0200, Jesper Dangaard Brouer wrote: > As the module uses rcu_call() we should make sure that all > rcu callback has been completed before removing the code. Good improvement!!! Assuming that gss_svc_shutdown() and rpcauth_unregister() prevent any future RCU callbacks to be registered, this patch will fix things up. Acked-by: Paul E. McKenney > Signed-off-by: Jesper Dangaard Brouer > --- > > net/sunrpc/auth_gss/auth_gss.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > index e630b38..66d458f 100644 > --- a/net/sunrpc/auth_gss/auth_gss.c > +++ b/net/sunrpc/auth_gss/auth_gss.c > @@ -1548,6 +1548,7 @@ static void __exit exit_rpcsec_gss(void) > { > gss_svc_shutdown(); > rpcauth_unregister(&authgss_ops); > + rcu_barrier(); /* Wait for completion of call_rcu()'s */ > } > > MODULE_LICENSE("GPL"); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/