MIME-Version: 1.0
In-Reply-To: <20090608124719.7c36840b@hskinnemoen-d830>
References: <c8284b5b0905281440hd2e4993re3d0d8c590713fa0@mail.gmail.com>
	 <4A1FFEFB.6050104@drewtech.com>
	 <c8284b5b0906020953o7c112b4hc264b5520cc3aed1@mail.gmail.com>
	 <4A269251.8090706@atmel.com> <4A269A83.3020008@drewtech.com>
	 <c8284b5b0906031202u18433b52s1a0718ef627fddf0@mail.gmail.com>
	 <20090608124719.7c36840b@hskinnemoen-d830>
Date: Mon, 8 Jun 2009 09:58:09 -0700
Message-ID: <c8284b5b0906080958o65a97a8dm914aa8b4c6e7a821@mail.gmail.com>
Subject: Re: [PATCH][Updated] New AT91 MCI Driver that supports both MCI slots 
	used at the same time
From: Rob Emanuele <poorarm@shoreis.com>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Joey Oravec <joravec@drewtech.com>,
       Nicolas Ferre <nicolas.ferre@atmel.com>,
       linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org,
       Haavard Skinnemoen <hskinnemoen@atmel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1827
Lines: 48

Hi Haavard,

I'd be happy to reintegrate my changes to this back into the Atmel
driver once I get it working correct on the at91.  Do you have the
equipment to give my changes a try?

Converting my #defines for the the features to cpu_is_xxx is easy
enough.  I'll take care of that.

Thanks,

Rob

On Mon, Jun 8, 2009 at 3:47 AM, Haavard
Skinnemoen<haavard.skinnemoen@atmel.com> wrote:
> Rob Emanuele wrote:
>> This driver is a port the Atmel AVR32 MCI driver which uses similar silicon.
>
> While I do understand the motivation for this patch, I was kind of
> hoping we could reduce the number of drivers for the Atmel MCI
> hardware, not increase it...
>
> So I think it would be much better if your changes were integrated into
> one of the existing drivers.
>
>> Joey Oravec has mentioned that he has had better reliability with the chip
>> he is using (AT91SAM9261) if the MMC controller is reset before each
>> command. ?There is a compile time option to do just that.
>
> This could be a useful option for atmel-mci too.
>
>> Joey Oravec has stated that the Read and Write Proof functionality that
>> prevents buffer overflows is not available on the AT91SAM9261. ?This was
>> confirmed by Nicolas Ferre and also affects the AT91RM9200. ?This new
>> patch excludes those register config bits.
>
> Preferably use the cpu_is_xxx() functions to achieve that. Perhaps even
> wrap those tests inside a mci_has_xxproof() function to make it
> clearer what you're testing for, and easier to change if we decide to
> do the test based on version registers, etc. later.
>
> Haavard
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/