Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbZFHS7S (ORCPT ); Mon, 8 Jun 2009 14:59:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751377AbZFHS7G (ORCPT ); Mon, 8 Jun 2009 14:59:06 -0400 Received: from fg-out-1718.google.com ([72.14.220.153]:23575 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955AbZFHS7F convert rfc822-to-8bit (ORCPT ); Mon, 8 Jun 2009 14:59:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <4A1FFEFB.6050104@drewtech.com> <4A269251.8090706@atmel.com> <4A269A83.3020008@drewtech.com> <20090608124719.7c36840b@hskinnemoen-d830> Date: Mon, 8 Jun 2009 11:59:06 -0700 X-Google-Sender-Auth: 9b7da846ba6855fb Message-ID: Subject: Re: [PATCH][Updated] New AT91 MCI Driver that supports both MCI slots used at the same time From: Rob Emanuele To: Haavard Skinnemoen Cc: Joey Oravec , Nicolas Ferre , linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, Haavard Skinnemoen Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2170 Lines: 60 Haavard, I'll revise my previous thought about integrating my changes back into the Atmel driver. I'll start that today. I figure this way, the changes I make can get in front of a wider audience. Thanks, Rob On Mon, Jun 8, 2009 at 9:58 AM, Rob Emanuele wrote: > Hi Haavard, > > I'd be happy to reintegrate my changes to this back into the Atmel > driver once I get it working correct on the at91. ?Do you have the > equipment to give my changes a try? > > Converting my #defines for the the features to cpu_is_xxx is easy > enough. ?I'll take care of that. > > Thanks, > > Rob > > On Mon, Jun 8, 2009 at 3:47 AM, Haavard > Skinnemoen wrote: >> Rob Emanuele wrote: >>> This driver is a port the Atmel AVR32 MCI driver which uses similar silicon. >> >> While I do understand the motivation for this patch, I was kind of >> hoping we could reduce the number of drivers for the Atmel MCI >> hardware, not increase it... >> >> So I think it would be much better if your changes were integrated into >> one of the existing drivers. >> >>> Joey Oravec has mentioned that he has had better reliability with the chip >>> he is using (AT91SAM9261) if the MMC controller is reset before each >>> command. ?There is a compile time option to do just that. >> >> This could be a useful option for atmel-mci too. >> >>> Joey Oravec has stated that the Read and Write Proof functionality that >>> prevents buffer overflows is not available on the AT91SAM9261. ?This was >>> confirmed by Nicolas Ferre and also affects the AT91RM9200. ?This new >>> patch excludes those register config bits. >> >> Preferably use the cpu_is_xxx() functions to achieve that. Perhaps even >> wrap those tests inside a mci_has_xxproof() function to make it >> clearer what you're testing for, and easier to change if we decide to >> do the test based on version registers, etc. later. >> >> Haavard >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/