Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753670AbZFHUuS (ORCPT ); Mon, 8 Jun 2009 16:50:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751013AbZFHUuH (ORCPT ); Mon, 8 Jun 2009 16:50:07 -0400 Received: from smtp3.ultrahosting.com ([74.213.175.254]:55685 "EHLO smtp.ultrahosting.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751130AbZFHUuG (ORCPT ); Mon, 8 Jun 2009 16:50:06 -0400 Date: Mon, 8 Jun 2009 16:49:45 -0400 (EDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Robin Holt cc: linux-kernel@vger.kernel.org, Tejun Heo , mingo@elte.hu, rusty@rustcorp.com.au, davem@davemloft.net Subject: Re: [this_cpu_xx 04/11] Use this_cpu ops for network statistics In-Reply-To: <20090608112736.GL29447@sgi.com> Message-ID: References: <20090605191819.376530498@gentwo.org> <20090605191851.012334412@gentwo.org> <20090608112736.GL29447@sgi.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 487 Lines: 14 On Mon, 8 Jun 2009, Robin Holt wrote: > > + this_cpu_inc((net)->ct.stat->count) > > Why not put this on one line? > #define NF_CT_STAT_INC_ATOMIC(net, count) this_cpu_inc((net)->ct.stat->count) Would be more than 78 characters in a line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/