Date: Mon, 8 Jun 2009 22:54:06 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <cl@linux-foundation.org>,
       Andy Whitcroft <apw@canonical.com>
Cc: Robin Holt <holt@sgi.com>, linux-kernel@vger.kernel.org,
       Tejun Heo <tj@kernel.org>, rusty@rustcorp.com.au, davem@davemloft.net
Subject: Re: [this_cpu_xx 04/11] Use this_cpu ops for network statistics
Message-ID: <20090608205406.GB13343@elte.hu>
References: <20090605191819.376530498@gentwo.org> <20090605191851.012334412@gentwo.org> <20090608112736.GL29447@sgi.com> <alpine.DEB.1.10.0906081649020.12271@gentwo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.1.10.0906081649020.12271@gentwo.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 804
Lines: 23


* Christoph Lameter <cl@linux-foundation.org> wrote:

> On Mon, 8 Jun 2009, Robin Holt wrote:
> 
> > > +	this_cpu_inc((net)->ct.stat->count)
> >
> > Why not put this on one line?
> > #define NF_CT_STAT_INC_ATOMIC(net, count)  this_cpu_inc((net)->ct.stat->count)
> 
> Would be more than 78 characters in a line.

I think you can ignore such types of warnings in general. I think 
checkpatch should be silent up to 90 chars or so, if there's not 
more than say 3 tabs in that line. (if there's a lot of tabs that 
means the indentation level is wrong.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/