Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760034AbZFIKA1 (ORCPT ); Tue, 9 Jun 2009 06:00:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755898AbZFIKAT (ORCPT ); Tue, 9 Jun 2009 06:00:19 -0400 Received: from mail-gx0-f214.google.com ([209.85.217.214]:56304 "EHLO mail-gx0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755168AbZFIKAS (ORCPT ); Tue, 9 Jun 2009 06:00:18 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=HHOr1XukdM0SV00/BSLi2ElgPlS/gw+xeUjYD3s4EyyJREa2xSWr4RkQpFXPOLckZe zQDOQgccK8/B8JT0xbTMzCR+tU3BHykwQwBQAMycIljhMFo6AGgVBgqhNc2rr2IgG0ZD QvJKlCzvuxE3MKYB5Z0NIiPxNSo+XJ/G50iiQ= MIME-Version: 1.0 In-Reply-To: <20090609181505.4083a213.kamezawa.hiroyu@jp.fujitsu.com> References: <20090609181505.4083a213.kamezawa.hiroyu@jp.fujitsu.com> Date: Tue, 9 Jun 2009 19:00:20 +0900 Message-ID: <28c262360906090300s13f4ee09mcc9622c1e477eaad@mail.gmail.com> Subject: Re: [BUGFIX][PATCH] fix wrong lru rotate back at lumpty reclaim From: Minchan Kim To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "kosaki.motohiro@jp.fujitsu.com" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , riel@redhat.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha.home.local id n59A6M54019451 Content-Length: 2221 Lines: 9 On Tue, Jun 9, 2009 at 6:15 PM, KAMEZAWAHiroyuki wrote:>> From: KAMEZAWA Hiroyuki >> In lumpty reclaim, "cursor_page" is found just by pfn. Then, we don't know> from which LRU "cursor" page came from. Then, putback it to "src" list is BUG.> Just leave it as it is.> (And I think rotate here is overkilling even if "src" is correct.)>> Signed-off-by: KAMEZAWA Hiroyuki > --->  mm/vmscan.c |    5 ++--->  1 file changed, 2 insertions(+), 3 deletions(-)>> Index: mmotm-2.6.30-Jun4/mm/vmscan.c> ===================================================================> --- mmotm-2.6.30-Jun4.orig/mm/vmscan.c> +++ mmotm-2.6.30-Jun4/mm/vmscan.c> @@ -940,10 +940,9 @@ static unsigned long isolate_lru_pages(u>                                nr_taken++;>                                scan++;>                                break;> ->                        case -EBUSY: We can remove case -EBUSY itself, too.It is meaningless. > -                               /* else it is being freed elsewhere */> -                               list_move(&cursor_page->lru, src);> +                               /* Do nothing because we don't know where> +                                  cusrsor_page comes from */>                        default:>                                break;  /* ! on LRU or wrong list */ Hmm.. what meaning of this break ?We are in switch case.This "break" can't go out of loop.But comment said "abort this block scan". If I understand it properly , don't we add goto phrase ? >                        }>> --> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in> the body of a message to majordomo@vger.kernel.org> More majordomo info at  http://vger.kernel.org/majordomo-info.html> Please read the FAQ at  http://www.tux.org/lkml/> -- Kinds regards,Minchan Kim????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?