Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757048AbZFILUj (ORCPT ); Tue, 9 Jun 2009 07:20:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756792AbZFILUa (ORCPT ); Tue, 9 Jun 2009 07:20:30 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:36529 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756547AbZFILU3 (ORCPT ); Tue, 9 Jun 2009 07:20:29 -0400 Message-ID: In-Reply-To: <28c262360906090300s13f4ee09mcc9622c1e477eaad@mail.gmail.com> References: <20090609181505.4083a213.kamezawa.hiroyu@jp.fujitsu.com> <28c262360906090300s13f4ee09mcc9622c1e477eaad@mail.gmail.com> Date: Tue, 9 Jun 2009 20:20:29 +0900 (JST) Subject: Re: [BUGFIX][PATCH] fix wrong lru rotate back at lumpty reclaim From: "KAMEZAWA Hiroyuki" To: "Minchan Kim" Cc: "KAMEZAWA Hiroyuki" , "linux-mm@kvack.org" , "kosaki.motohiro@jp.fujitsu.com" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , riel@redhat.com User-Agent: SquirrelMail/1.4.16 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-2022-jp Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1964 Lines: 71 Minchan Kim wrote: > On Tue, Jun 9, 2009 at 6:15 PM, KAMEZAWA > Hiroyuki wrote: >> >> From: KAMEZAWA Hiroyuki >> >> In lumpty reclaim, "cursor_page" is found just by pfn. Then, we don't >> know >> from which LRU "cursor" page came from. Then, putback it to "src" list >> is BUG. >> Just leave it as it is. >> (And I think rotate here is overkilling even if "src" is correct.) >> >> Signed-off-by: KAMEZAWA Hiroyuki >> --- >> mm/vmscan.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> Index: mmotm-2.6.30-Jun4/mm/vmscan.c >> =================================================================== >> --- mmotm-2.6.30-Jun4.orig/mm/vmscan.c >> +++ mmotm-2.6.30-Jun4/mm/vmscan.c >> @@ -940,10 +940,9 @@ static unsigned long isolate_lru_pages(u >> nr_taken++; >> scan++; >> break; >> - >>case -EBUSY: > > We can remove case -EBUSY itself, too. > It is meaningless. > Sure, will post v2 and remove EBUSY case. (I'm sorry my webmail system converts a space to a multibyte char... then I cut some.) >> - /* else it is being freed >> elsewhere */ >> - >> list_move(&cursor_page->lru, src); >> + /* Do nothing because we >> don't know where >> + cusrsor_page comes >> from */ >>default: >> break; /* ! on LRU or >> wrong list */ > > Hmm.. what meaning of this break ? > We are in switch case. > This "break" can't go out of loop. yes. > But comment said "abort this block scan". > Where ? the comment says the cursor_page is not on lru (PG_lru is unset) > If I understand it properly , don't we add goto phrase ? > No. Just try next page on list. Thank you for review, I'll post updated one tomorrow. -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/