Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758937AbZFILak (ORCPT ); Tue, 9 Jun 2009 07:30:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758205AbZFILac (ORCPT ); Tue, 9 Jun 2009 07:30:32 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:44748 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756847AbZFILac (ORCPT ); Tue, 9 Jun 2009 07:30:32 -0400 Subject: Re: [patch 19/87] Fix oops on close of hot-unplugged FTDI serial converter From: David Woodhouse To: Greg KH , Alan Stern Cc: "linux-kernel@vger.kernel.org" , "stable@kernel.org" , Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , Jake Edge , Eugene Teo , "torvalds@linux-foundation.org" , "akpm@linux-foundation.org" , "alan@lxorguk.ukuu.org.uk" In-Reply-To: <20090609094056.465155618@blue.kroah.org> References: <20090609093848.204935043@blue.kroah.org> <20090609094056.465155618@blue.kroah.org> Content-Type: text/plain Date: Tue, 09 Jun 2009 12:30:11 +0100 Message-Id: <1244547011.4538.7.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.26.2 (2.26.2-1.fc11) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 877 Lines: 21 On Tue, 2009-06-09 at 02:39 -0700, Greg KH wrote: > 2.6.29-stable review patch. If anyone has any objections, please let > us know. Many USB-serial drivers have similar problems; Alan Stern posted a better fix which splits the shutdown() method into separate disconnect() and release(). Admittedly, he didn't include ftdi in his patch because it already had this workaround submitted -- but Alan's approach is better. We should probably fix ftdi that way, not with this patch. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/