Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760930AbZFINDT (ORCPT ); Tue, 9 Jun 2009 09:03:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756122AbZFINDN (ORCPT ); Tue, 9 Jun 2009 09:03:13 -0400 Received: from mga03.intel.com ([143.182.124.21]:41412 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755483AbZFINDM (ORCPT ); Tue, 9 Jun 2009 09:03:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.41,331,1241420400"; d="scan'208";a="152247376" Date: Tue, 9 Jun 2009 21:03:04 +0800 From: Wu Fengguang To: Nick Piggin Cc: Andi Kleen , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH] [11/16] HWPOISON: check and isolate corrupted free pages v2 Message-ID: <20090609130304.GF5589@localhost> References: <20090603846.816684333@firstfloor.org> <20090603184645.68FA21D0286@basil.firstfloor.org> <20090609100229.GE14820@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090609100229.GE14820@wotan.suse.de> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2206 Lines: 73 On Tue, Jun 09, 2009 at 06:02:29PM +0800, Nick Piggin wrote: > On Wed, Jun 03, 2009 at 08:46:45PM +0200, Andi Kleen wrote: > > > > From: Wu Fengguang > > > > If memory corruption hits the free buddy pages, we can safely ignore them. > > No one will access them until page allocation time, then prep_new_page() > > will automatically check and isolate PG_hwpoison page for us (for 0-order > > allocation). > > It would be kinda nice if this could be done in the handler > directly (ie. take the page directly out of the allocator > or pcp list). Completely avoiding fastpaths would be a > wonderful goal. In fact Andi have code to do that. We prefer this one because - it's simple - it's good sanity check for possible software BUGs - it mainly adds overhead to high order pages, which is acceptable Thanks, Fengguang > > > > + /* Don't complain about poisoned pages */ > > + if (PageHWPoison(page)) { > > + __ClearPageBuddy(page); > > + return; > > + } > > + I do think the above chunk is not absolutely necessary, though. Thanks, Fengguang > > /* > > * Allow a burst of 60 reports, then keep quiet for that minute; > > * or allow a steady drip of one report per second. > > @@ -650,7 +656,7 @@ > > /* > > * This page is about to be returned from the page allocator > > */ > > -static int prep_new_page(struct page *page, int order, gfp_t gfp_flags) > > +static inline int check_new_page(struct page *page) > > { > > if (unlikely(page_mapcount(page) | > > (page->mapping != NULL) | > > @@ -659,6 +665,18 @@ > > bad_page(page); > > return 1; > > } > > + return 0; > > +} > > + > > +static int prep_new_page(struct page *page, int order, gfp_t gfp_flags) > > +{ > > + int i; > > + > > + for (i = 0; i < (1 << order); i++) { > > + struct page *p = page + i; > > + if (unlikely(check_new_page(p))) > > + return 1; > > + } > > > > set_page_private(page, 0); > > set_page_refcounted(page); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/