Subject: Re: [PATCH] X86: cpu_debug support for VIA / Centaur CPU's
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Harald Welte <HaraldWelte@viatech.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
       Ingo Molnar <mingo@elte.hu>
In-Reply-To: <20090609145305.GD3986@prithivi.gnumonks.org>
References: <20090609082931.GD25316@prithivi.gnumonks.org>
	 <1244537598.2558.9.camel@ht.satnam>
	 <20090609145305.GD3986@prithivi.gnumonks.org>
Content-Type: text/plain
Date: Tue, 09 Jun 2009 20:48:50 +0530
Message-Id: <1244560731.2509.32.camel@ht.satnam>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1515
Lines: 43

On Tue, 2009-06-09 at 22:53 +0800, Harald Welte wrote:
> Thanks for your quick response.
> 
> On Tue, Jun 09, 2009 at 02:23:18PM +0530, Jaswinder Singh Rajput wrote:
>  
> > On Tue, 2009-06-09 at 16:29 +0800, Harald Welte wrote:
> > > This patch adds the MSR definitions for the VIA/Centaur CPU models
> > > to cpu_debug.c
> > > 
> > > Signed-off-by: Harald Welte <HaraldWelte@viatech.com>
> > 
> > As per Ingo suggestion, we removed model information from cpu_debug and
> > is available in -tip :
> 
> but what happens if one MSR has a different group from vendor A to vendor B?
> and what happens if you read MSR's on a CPU that doesn't have them?  I suppose
> you get a segmentation fault, at least that's what I've received in the past
> when accidentially reading a MSR that doesn't exist.  Is that what the _safe_
> variant of rdmsr is for?
> 

AFAIK we are using safe variant. That's why I requested you to test
latest -tip and let us know your result and feedback.

> > 
> > Currently I am doing more changes and available in :
> > 
> > http://git.kernel.org/?p=linux/kernel/git/jaswinder/linux-2.6-cpu.git;a=shortlog;h=x86/cpu
> 
> Which means I should base on which of those tree to make sure it can be merged?
> 

-tip will be better option.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/