Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758150AbZFIQma (ORCPT ); Tue, 9 Jun 2009 12:42:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755855AbZFIQmE (ORCPT ); Tue, 9 Jun 2009 12:42:04 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53600 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754725AbZFIQmD (ORCPT ); Tue, 9 Jun 2009 12:42:03 -0400 Date: Tue, 9 Jun 2009 09:41:08 -0700 (PDT) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Dave Jones cc: Rusty Russell , Yinghai Lu , Avi Kivity , Ingo Molnar , Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , cpufreq@vger.kernel.org Subject: Re: [PATCH 4/6] x86/cpufreq: use cpumask_copy instead of = In-Reply-To: <20090609162808.GC2491@redhat.com> Message-ID: References: <4A2835D8.6040903@kernel.org> <4A2AE4AC.60805@kernel.org> <4A2AE570.2010307@kernel.org> <200906091627.45411.rusty@rustcorp.com.au> <20090609162808.GC2491@redhat.com> User-Agent: Alpine 2.01 (LFD 1184 2008-12-16) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 595 Lines: 20 On Tue, 9 Jun 2009, Dave Jones wrote: > > work_on_cpu()'s definition could probably use a fat comment describing > why it sucks. No, it should be renamed. The problem is that it _sounds_ like a nice thing to do. If it was called "slow_other_cpu_thread_switch_with_a_donkey_on_top()", I bet people wouldn't be so damn eager to use it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/