Date: Tue, 9 Jun 2009 18:07:38 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Oskar Schirmer" <os@emlix.com>
Cc: Oskar Schirmer <os@emlix.com>, Sascha Hauer <kernel@pengutronix.de>,
       linux-kernel@vger.kernel.org, Fabian Godehardt <fg@emlix.com>
Subject: Re: [PATCH 8/8] imx: serial: add IrDA support to serial driver
Message-ID: <20090609180738.10014627@lxorguk.ukuu.org.uk>
In-Reply-To: <20090609161817.GA17246@emlix.com>
References: <1244555211-15618-1-git-send-email-os@emlix.com>
	<1244555211-15618-2-git-send-email-os@emlix.com>
	<1244555211-15618-3-git-send-email-os@emlix.com>
	<1244555211-15618-4-git-send-email-os@emlix.com>
	<1244555211-15618-5-git-send-email-os@emlix.com>
	<1244555211-15618-6-git-send-email-os@emlix.com>
	<1244555211-15618-7-git-send-email-os@emlix.com>
	<1244555211-15618-8-git-send-email-os@emlix.com>
	<1244555211-15618-9-git-send-email-os@emlix.com>
	<20090609160132.31265ffc@lxorguk.ukuu.org.uk>
	<20090609161817.GA17246@emlix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 746
Lines: 20

> Sure, the path will be optimized away, but still
> the conditional statement is subjected to syntax
> and scope analysis and gcc will correctly complain
> that irda_inv_rx is not declared.

Why are only about half of them done this way rather than all ?

> peripheral register settings, because the old baud rate
> calculation was not accurate enough for IrDA use.
> That's why we introduced the approximation function
> (and finally generalised it into lib/).

Yes - I'm fine with that part.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/