Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758508AbZFISDu (ORCPT ); Tue, 9 Jun 2009 14:03:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754604AbZFISDn (ORCPT ); Tue, 9 Jun 2009 14:03:43 -0400 Received: from brick.kernel.dk ([93.163.65.50]:42901 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751997AbZFISDm (ORCPT ); Tue, 9 Jun 2009 14:03:42 -0400 Date: Tue, 9 Jun 2009 20:03:44 +0200 From: Jens Axboe To: Kiyoshi Ueda Cc: linux-kernel@vger.kernel.org, device-mapper development , "Jun'ichi Nomura" Subject: Re: [PATCH block#for-2.6.31] block: add request clone interface Message-ID: <20090609180344.GQ11363@kernel.dk> References: <4A2E1490.7060902@ct.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A2E1490.7060902@ct.jp.nec.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 29 On Tue, Jun 09 2009, Kiyoshi Ueda wrote: > Hi Jens, > > +/* > + * Copy request information of the original request to the clone request. > + */ > +static void __blk_rq_prep_clone(struct request *dst, struct request *src) > +{ > + dst->cpu = src->cpu; > + dst->cmd_flags = (rq_data_dir(src) | REQ_NOMERGE); > + dst->cmd_type = src->cmd_type; > + dst->__sector = blk_rq_pos(src); > + dst->__data_len = blk_rq_bytes(src); > + dst->nr_phys_segments = src->nr_phys_segments; > + dst->ioprio = src->ioprio; > + dst->buffer = src->buffer; > + dst->cmd_len = src->cmd_len; > + dst->cmd = src->cmd; Are you making sure that 'src' always exists while 'dst' is alive? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/